Repository navigation
Device types: named sets (raftcore:@common) in selections and the catalogue - #24
Merged
Merged
Conversation
…atalogue resolveDeviceTypeSelection takes "<bundled source>:@<set>" in include and exclude, as RaftCore's assembler does (shared selection vectors); DeviceTypeSourceRecords carries a source's sets, which RaftCoreCatalogue reads from the published catalogue.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows robdobsn/RaftCore#30, which adds RaftCore's named device type sets.
resolveDeviceTypeSelectiontakes"<bundled source>:@<set>"inincludeandexclude, with the assembler's rules and errors. It's tested on RaftCore's shared selection vectors (copied intotestdata/).DeviceTypeSourceRecords.sets: a source's sets, whichRaftCoreCatalogue.records()reads from the publishedcatalogue.json.Testing: 429 pass. tsc (web, React Native, the Device Types app) and eslint are clean.
🤖 Generated with Claude Code