Skip to content

fix(synced-lyrics): stop Musixmatch from failing on every song - #48

Merged
bercedev merged 5 commits into
masterfrom
fix/musixmatch-token
Nov 18, 2026
Merged

bercedev merged 5 commits into
masterfrom
fix/musixmatch-token

Conversation

@bercedev

Copy link
Copy Markdown
Member

musixmatch's anonymous desktop token now comes back as all zeros (checked with curl: http 200, user_token 000...), so the provider threw "Failed to get token" on every song. this keeps the console quiet: one shared init, the zero token counts as unavailable (retry after 1 h, 10 min on network errors), one warning per cooldown. a real fix needs a musixmatch account token, like pear-devs/pear-desktop#4751. tests: token check test added, typecheck, lint, build pass in a network-less box. not run live.

musixmatch now answers the anonymous desktop token request with an all-zero token, which threw "Failed to get token" for every song. share one init across songs, treat the zero token as unavailable and retry after an hour (10 min on network errors), warning once per cooldown.
…he outages

a rejected token now gets one retry with a fresh token before the cooldown, an expired token is refreshed before searching, and a song played during a cooldown isn't stored as "no lyrics", so it gets lyrics once musixmatch answers again.
@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

berce and others added 2 commits November 18, 2026 14:00
…wn ends

a song that keeps playing through the cooldown gets one more search when it ends, and a late token rejection no longer replaces a token that was just refreshed.
the store-side retry timer kept adding edge cases. the search cache only lives for the session and other providers still answer, so during a cooldown musixmatch just returns no result. token retry, expiry refresh and the cooldown stay in the provider.
@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@bercedev
bercedev merged commit 7c19a9a into master Nov 18, 2026
7 checks passed
@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

@github-actions

Copy link
Copy Markdown

🚀 Build Artifacts Ready!

The builds have completed successfully. You can download the artifacts from the workflow run:

📦 Download Artifacts

Available builds:

  • Windows: build-artifacts-windows-latest
  • macOS: build-artifacts-macos-latest
  • Linux: build-artifacts-ubuntu-latest

Note: Artifacts are available for 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants