Repository navigation
fix(synced-lyrics): stop Musixmatch from failing on every song - #48
Merged
Merged
Conversation
musixmatch now answers the anonymous desktop token request with an all-zero token, which threw "Failed to get token" for every song. share one init across songs, treat the zero token as unavailable and retry after an hour (10 min on network errors), warning once per cooldown.
…he outages a rejected token now gets one retry with a fresh token before the cooldown, an expired token is refreshed before searching, and a song played during a cooldown isn't stored as "no lyrics", so it gets lyrics once musixmatch answers again.
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
…wn ends a song that keeps playing through the cooldown gets one more search when it ends, and a late token rejection no longer replaces a token that was just refreshed.
the store-side retry timer kept adding edge cases. the search cache only lives for the session and other providers still answer, so during a cooldown musixmatch just returns no result. token retry, expiry refresh and the cooldown stay in the provider.
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
# Conflicts: # changelog.md
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
🚀 Build Artifacts Ready!The builds have completed successfully. You can download the artifacts from the workflow run: Available builds:
Note: Artifacts are available for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
musixmatch's anonymous desktop token now comes back as all zeros (checked with curl: http 200, user_token 000...), so the provider threw "Failed to get token" on every song. this keeps the console quiet: one shared init, the zero token counts as unavailable (retry after 1 h, 10 min on network errors), one warning per cooldown. a real fix needs a musixmatch account token, like pear-devs/pear-desktop#4751. tests: token check test added, typecheck, lint, build pass in a network-less box. not run live.