Repository navigation
cardkit-server: sweep seeds in the bot-name collision test - #20
Merged
Merged
Conversation
Carries over the stronger version of this assertion from the 500 app, which is where pickBotNames used to live: it sweeps 50 seeds rather than trusting one, and also checks the picked names are unique among themselves. This lets 500 drop its copy in the adoption PR instead of keeping a test for code it no longer owns. The test exercises cardkit's default pool and cardkit's helper, neither of which is game-specific, so the coverage belongs here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019EH6XkA2oEhv4YnMXt8hbJ Signed-off-by: rotund_tapir <rotund_tapir@protonmail.com>
rotundtapir
commented
Jul 29, 2026
rotundtapir
left a comment
rotundtapir
left a comment
Owner
Author
There was a problem hiding this comment.
Test-only, case-insensitive collision + uniqueness swept across 50 seeds, correctly relocated with the helper it tests. CI green, single commit authored/pushed by rotundtapir. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries over the stronger version of this test from the 500 app, which is where
pickBotNamesused to live. It sweeps 50 seeds instead of trusting one, and also asserts the picked names are unique among themselves.Doing this lets 500 drop its copy in the adoption PR rather than keep testing code it no longer owns — and it tests cardkit's default pool and cardkit's helper, neither of which is game-specific, so this is where the coverage belongs.
Test-only.
🤖 Generated with Claude Code
https://claude.ai/code/session_019EH6XkA2oEhv4YnMXt8hbJ