Repository navigation
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Collaborator
|
Thanks @pierry01! This landed on main through #579, which carried #659 on top of it: the same badge and toolbar-spacing fixes, the same checkbox divergences, plus the status icons from the block. The Columns trigger is fixed instead of registered (the toggle's wrappers are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
None opened. Follow-up of the shadcn audit on #579.
Description
The DataTable left 16px between the toolbar and the table; shadcn's dashboard-01 block leaves 24px (the toolbar sits in
Tabs gap-6).DataTableToolbarnow addspb-2on top of the root'sspace-y-4, so the table, rows, summary and pagination land on the same coordinates as shadcn's at 1280×800.The other two ❌ the audit reported render the same and are now registered with a
matchinaudit/divergences/data_table.yml:display: inline-flexvsflex: same classes; shadcn's button is a flex item and gets blockified, RubyUI's sits inside the DropdownMenu wrappers. Same box.display: block/text-align: startvs the Base UI<span>'sflex/left: the native input has no children or text to lay out. Same 16×16 box.The RubyUI audit fixture now renders the badges as shadcn's does (
px-1.5 text-muted-foreground), which also removes a 1px per row difference.shadcn audit · main
shadcn audit · this PR
The per-page select ❌ in both lists is fixed by #579.
Testing instructions
cd gem && bundle exec rake→ 776 runs, 0 failures, StandardRB clean./docs/data_table: the table starts 24px below the toolbar.cd audit && bundle exec exe/shadcn-audit collect data_table …→ the Columns trigger and row checkbox lines come out ✅ intentional.🤖 Generated with Claude Code
Summary by cubic
Fixes the DataTable toolbar gap so the table lands 24px below the toolbar, matching shadcn's dashboard-01 block at 1280×800, and registers three look differences that render identically as intentional divergences in the audit.
DataTableToolbargainspb-2on top ofDataTable'sspace-y-4; the gap was previously 16px.inline-flexand the row checkbox'sblock/startas intentional matches inaudit/divergences/data_table.yml; the resulting boxes are identical on both sides.px-1.5 text-muted-foreground, matching shadcn's classes and removing a 1px-per-row difference.Written for commit ceffe44. Summary will update on new commits.