Repository navigation
Public copy: documents and citations first, no default model, one answer per question - #2
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4af7284a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…no default model Hero, subhead and who-it-is-for line from the approved positioning; the Status caveats move below the quick start; Docker sets the provider next to the model; the model reference moves to docs/operations.md; sync is listed as advanced and optional; notes are indexed, compiling the journal comes in v1.3.
…l probe The provider menu from the installer and init, the Claude models that do not work yet, llm show and llm set (moved from the README), what preflight checks with and without --model-probe, and the service command with --maintenance.
…ys made No default provider or model, no local proxy default; non-interactive runs need LIFECONTEXT_PROVIDER and LIFECONTEXT_MODEL; the installer checks the model and ends with three next steps; the install line and the image are described as published, with the checkout build as an alternative.
…advanced EN and UK: the new H1, subhead and who-it-is-for line, title, description and link-card text; the install tab follows the README's three steps; no default provider; Python 3.12 and service install --maintenance for a source install; Tesseract through Homebrew, apt, dnf or pacman; FAQ entries on notes (indexed, compiled from v1.3), several devices (advanced, optional) and who it is not for. The UK copy uses colons instead of em dashes.
preflight does not check the model but the engine start sends it one tiny test request; the model probe is a short check, not one call; skill links are made unless an unattended init fails; Docker marks provider and model as required; the README Status dates the first release; the journal line names Journal/Inbox and capture; Tesseract is optional for a source install; PATH hint in the quick start; Ukrainian wording fixes.
On Anthropic, retain's strict structured output is a forced tool call; the Anthropic adapter sends no tool_choice for reflect. Matches Lane A's refusal message.
Every model-probe cause and the probe's JSON fields; the installer skips the probe until the setup is complete and prints the next steps only when the model check did not fail; doctor's model_probe_failed, model_reflect_check_failed and model_rejects_forced_tool_use; the menu asks again up to three times; the container also waits for a model key.
… the sync guide says
Hantok
force-pushed
the
claude/p0-lane-b-copy-f523a4
branch
from
October 22, 2026 18:49
c4af728 to
5ec664a
Compare
Hantok
marked this pull request as ready for review
October 22, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane B of the v1.2.0 P0 plan: public copy and consistency (audit items 2 and 3). The owner approved the copy (O1) together with merging the four lanes. Rebased onto
mainafter Lane A (#4,28ee24c), step 0's sync guide, Lane C and Lane D; the final pass checked every installer andinitsentence against the merged code and fixed the differences (2802a8f,5ec664a).What changed
README
maindoes not promise a working command before the release; the 11-01 merge-back replaces it.docs/operations.md("Choosing the model"); the README keeps a short summary with a link.initask; the Docker example setsLIFECONTEXT_PROVIDER=anthropicnext toLIFECONTEXT_MODEL.docs/sync.md.docs/install.md: the provider menu from Lane A item 1, the model check (
preflight --model-probe, exit 3,--skip-model-probe),Journal/Inboxcapture question andLIFECONTEXT_CAPTURE, requiredLIFECONTEXT_PROVIDER/LIFECONTEXT_MODELfor unattended runs, skill links always made, Docker waiting without provider or model, no CLIProxyAPI or 8317, no "once the repository is public".docs/operations.md: new "Choosing the model" section (menu, the four Claude models that do not work,
llm show/llm set),initwithout defaults (provider_required,model_required,model_probe,next_steps/setup_steps,Journal/Inbox), whatpreflightchecks with and without--model-probe,service install --maintenance.Site (EN and UK): new
<title>, meta description,og:title,og:description; H1, subhead, who-it-is-for line and proof facts; the install tab follows the README's three steps; no default model and no featured provider; Python 3.12 andservice install --maintenancefor a source install; Tesseract through Homebrew, apt, dnf or pacman; FAQ entries "Are my notes compiled too?", "Can I use it on my phone or on several devices?" (advanced, optional) and "Who is it not for?". UK: no em dashes left (the eight became colons or were rephrased), written to the owner's Ukrainian style rules.site/llms.txt, site/sitemap.xml: the same promise and install facts;
lastmod2026-10-22.grep -rniE "not public yet|once the repository is public|until the 1.2.0 image|8317|CLIProxyAPI|anthropic by default|default .?anthropic|provider .anthropic." README.md docs/install.md docs/operations.md site/finds nothing.Proposed GitHub About (for the owner to set on 11-01; 345 of 350 characters)
Website field:
https://rundax.github.io/lifecontext/.CHANGELOG entry (for Lane D to add)
Independent review
A separate reviewer checked facts against the code and workflows, consistency between the README, the docs, both site pages and
llms.txt, the Lane A items against the plan, licence wording and the Ukrainian style rules. No blockers. Fixed:preflightnow says it does not check the model (starting the engine sends one tiny test request and only logs it); the probe is "a short check" (it makes two calls); the skill-link exception (a failing unattendedinitstops the installer first); Docker marks provider and model as required; Tesseract is optional for a source install; a PATH hint in the quick start; the dated Status line above; nine Ukrainian wording fixes. Not changed here:licence-metaclass for its spacing, becausesite/assets/site.cssis outside this lane's files.docs/sync.mdof step 0; merge after step 0.docker compose upfrom a checkout fall back to a long local build while the GHCR image is still private?Depends on, and checks left
claude-sonnet-5works andclaude-haiku-5-5costs less. If Spike C fails, those lines change.site/og.png,site/og-uk.pngand the social preview are Lane C's.