Repository navigation
ci: install golangci-lint in the release workflow - #7
Merged
Merged
Conversation
make lint has run golangci-lint since the architecture refactor, and ci.yml installs it, but release.yml did not: the v0.2.0 release failed at its Test step with "golangci-lint not found" before publishing anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make linthas needed golangci-lint since #5, andci.ymlinstalls it, butrelease.ymlwas not given the same step. Thev0.2.0release run (40319652700) failed at Test withgolangci-lint not found, before packaging or publishing.This copies
ci.yml's checksummed install step (same version and SHA-256) intorelease.ymlbefore Test.