-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
Tracking issue for cleaning up core's and std's panic machinery #116005
Copy link
Copy link
Open
Labels
A-panicArea: Panicking machineryArea: Panicking machineryC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Description
Activity
Metadata
Metadata
Labels
A-panicArea: Panicking machineryArea: Panicking machineryC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
We can probably clean a bunch of things up in
library/core/src/panic.rs,library/core/src/panicking.rs,library/core/src/panic/panic_info.rs,library/std/src/panic.rsandlibrary/std/src/panicking.rs.Here's an attempt of a sketch of the situation today:
(Edit: last diagram update: 2023-09-21)
(Note that a bunch of the complexity is the implementations of some of these functions, which is not visible in this diagram.)
PanicInfo::messageavailable in all situations MakePanicInfo::messageinfallible #115561r#trytocatch_unwind: rename 'try' intrinsic to 'catch_unwind' #121598rust_panic_without_hooktoresume_unwindRenamerust_panic_without_hooktoresume_unwind#144852rust_prefixes Remove unnecessaryrust_prefixes #144853begin_panicbegin_panic_handlerto justpanic_handlerRenamebegin_panic_handlertopanic_handler#144903