Add "diagnostic items" which behave like lang items #39131

Activity

1. brson

   added

   I-wishlist

   T-langRelevant to the language teamRelevant to the language team

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   and removed

   T-langRelevant to the language teamRelevant to the language team

   on Jan 18, 2017
2. Mark-Simulacrum

   added

   C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   and removed

   I-wishlist

   on Jul 26, 2017
3. Manishearth commented on Apr 7, 2019

   

   Manishearth

   on Apr 7, 2019

   MemberAuthor

   More actions

   More details in #58070 (comment)

   cc @oli-obk @phansch
4. Manishearth commented on Apr 7, 2019

   

   Manishearth

   on Apr 7, 2019

   MemberAuthor

   More actions

   Copying over the relevant comment:

   We add a new attribute to the compiler: #[diagnostic = "debug_trait"] and similar so we can stop checking for lang items and instead just check for diagnostic-specific items.

   This will be a bit more involved. Essentially we need to

   1. duplicate the get_lang_items query. Though I don't think there's any point in having a method per diagnostic item.
   2. So I suggest we just make the query return a FxHashMap<Symbol, NodeId>.
   3. We can then build a wrapper method on the TyCtxt that maps a &str to an Option<NodeId> for user convenience
   4. Throw the new attribute on a bunch of types (basically go through https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/utils/paths.rs and just flag all the things in that list)
   5. see if there are any rustc diagnostics that could benefit from this
   6. replace all uses of util/path.rs with a use of the &str -> Option<NodeId> method
   7. complain to @oli-obk that they didn't think this through and there's uses of util/path.rs that do something different
   8. figure out if we need any of this in EarlyLintPasses and make them LateLintPasses
   9. see 7.
5. Manishearth

   added

   A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.

   on Apr 7, 2019
6. oli-obk

   added

   E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.

   E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

   on Apr 8, 2019
7. bors

   added a commit that references this issue on Aug 30, 2019

   Auto merge of #60966 - oli-obk:diagnostic_items, r=eddyb

   ...

   c7d4df0
8. bors

   closed this as completedin c7d4df0on Aug 30, 2019
9. fmease

   added

   A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.

   and removed

   A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.

   on Dec 21, 2024