x.py build changed how paths are printed => hyperlinks (in e.g. emacs) do not work

At some point in the recent past, something in one or more of our tools has broken so that the paths printed during compilation errors/warnings are not presented relative to the current directory.

E.g., when I am building with current directory ~/Dev/Mozilla/rust-mirborrowck/objdir-dbgopt/, via the command ../x.py build --incremental --keep-stage 0 --stage 1 src/libstd, I now get output with errors like this:

Copying stage0 test from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling rustc_mir v0.0.0 (file:///home/pnkfelix/Dev/Mozilla/rust-mirborrowck/src/librustc_mir)
error: expected one of `=>`, `if`, or `|`, found `{`
   --> librustc_mir/borrow_check/mod.rs:949:36
    |
949 |             Rvalue::Len(ref place) {
    |                                    ^ expected one of `=>`, `if`, or `|` here

error: aborting due to previous error

error: Could not compile `rustc_mir`.

but the provided path, librustc_mir/borrow_check/mod.rs is meaningless in the context of my current directory; I need it to either be an absolute path, or a relative path like ../src/librustc_mir/borrow_check/mod.rs

This is of course easy for a veteran to work around by manually opening up the files in question, which is why I suspect no one had filed this issue yet. But its probably really bad for a newcomer, and its an annoyance even for veterans.

@alexcrichton

This seems to be due to rust-lang/cargo#4788.

cc @alexcrichton

@Zoxc

Yes this is due to the PR @Zoxc linked. We could fix this in rust-lang/rust by moving the Cargo.toml up to the root I believe.

Drives me crazy. I am currently using ./x.py build 2>&1 | sed s%--> lib%-->src/lib%, but I think that in general running ./x.py should print relative to the directory where you ran the command.

Fix how paths are printed by error messages during bootstrap

@alexcrichton

Just as an update: @alexcrichton wrote:

Yes this is due to the PR @Zoxc linked. We could fix this in rust-lang/rust by moving the Cargo.toml up to the root I believe.

But from reading the history of PR #47731 it appears that the strategy of moving Cargo.toml up to the root was not workable...

@pnkfelix

@pnkfelix are you still running into this issue? Similar errors in rustdoc print relative to the workspace root, is that the behavior you want? If so I think this can be closed.

error[E0432]: unresolved import `std::ev`
  --> src/librustdoc/lib.rs:62:5
   |
62 | use std::ev;
   |     ^^^^^--
   |     |    |
   |     |    help: a similar name exists in the module: `env`
   |     no `ev` in the root

I'm going to close this, I think it's since been fixed.

Navigation Menu

Repository navigation

x.py build changed how paths are printed => hyperlinks (in e.g. emacs) do not work #47355

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

x.py build changed how paths are printed => hyperlinks (in e.g. emacs) do not work #47355

Description

Activity

pnkfelix commented on Jan 11, 2018

Zoxc commented on Jan 11, 2018

alexcrichton commented on Jan 11, 2018

nikomatsakis commented on Jan 22, 2018

pnkfelix commented on May 4, 2018

jyn514 commented on Jan 1, 2021

jyn514 commented on Jun 27, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions