Repository navigation
Cargo and some dependencies are compiled twice on CI #48223
Description
I noticed on the most recently timed out mipsel dist builder that Cargo, the library, was compiled twice. This is no small chunk of time!
Investigating it looks like a number of libraries were compiled at least twice, including: cargo, chrono, crates-io, docopt, env_logger, failure_derive, failure, num, serde_derive_internals, serde_derive, synstructure.
My guess is that the feature selection is changing for deeply nested crates like syn or num between top-level targets like the RLS and Cargo. We should make sure that the feature selection is the same so the dependencies can be shared, and then we should probably add a check to CI that Cargo isn't compiled twice.
Activity
alexcrichton commentedon Feb 15, 2018
cc @Mark-Simulacrum, @kennytm
ishitatsuyuki commentedon Feb 15, 2018
I think I brought up this before, and as a result you closed the issue at Cargo side.
alexcrichton commentedon Feb 16, 2018
Cargo is working as intended, our CI is not
ishitatsuyuki commentedon Feb 16, 2018
So this is rust-lang/cargo#4048. I think this is definitely a feature worth implement in Cargo.
Update to syn 0.12
alexcrichton commentedon Mar 1, 2018
I think this will be fixed with nrc/derive-new#28 and #48642
alexcrichton commentedon Mar 7, 2018
Fixed in #48642