Repository navigation
10% performance regression after rollup #49051 #49168
Description
It's not quite clear what caused this regression, something in #49051. Pinging all committers from the range:
@jcowgill, @alexcrichton, @Eijebong, @mark-i-m, @kennytm, @Centril, @estebank, @snf, @ehuss, @Songbird0, @draganmladjenovic, @ExpHP, @petrochenkov
Any ideas? Did the rand crate get slower?
cc @rust-lang/wg-compiler-performance
Activity
michaelwoerister commentedon Mar 19, 2018
@alexcrichton oh, I see this regression is more or less expected due to ff227c4. Pity.
This shouldn't affect stable and beta binaries, right?
alexcrichton commentedon Mar 19, 2018
Yeah this is almost for sure re-enabling multiple codegen units on dist builds. I do believe this affects stable/beta binaries, but such a change has already hit stable (aka today's stable release)
michaelwoerister commentedon Mar 19, 2018
Can we switch to one CGU for stable releases?
alexcrichton commentedon Mar 19, 2018
Unfortunately not really, we're seriously bleeding for time on CI as-is and we're looking for any wins we can get anywhere. We can leave this open if we ever get enough time on CI, but otherwise I think we just can't afford to do this today
michaelwoerister commentedon Mar 19, 2018
OK, thanks for the info. I'll close this issue since the regression is accounted for.
sophiajt commentedon Mar 19, 2018
@michaelwoerister - sorry for jumping in, but is there a follow-up issue to track reclaiming this regressed time? One of our main deliverables this year is faster compile times, so each compile time regression is pretty serious.
Apologies if I'm misunderstanding the thread, just making sure we're keeping track of where we slip and where we need to recover.
michaelwoerister commentedon Mar 19, 2018
@jonathandturner I have an item on my todo list for setting up a tracking issue about building our releases as optimized as possible (including PGO, once that's available, and maybe full LTO). Should be up later today.
michaelwoerister commentedon Mar 19, 2018
@jonathandturner: #49180