Constant evaluation regression in beta 1.26 #49930

Activity

1. emilyalbini

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   A-const-fn

   C-bugCategory: This is a bug.Category: This is a bug.

   on Apr 13, 2018
2. emilyalbini

   added this to the 1.26 milestone on Apr 13, 2018
3. oli-obk commented on Apr 13, 2018

   

   oli-obk

   on Apr 13, 2018

   Contributor

   More actions

   fixing the ostn02_phf case is simple, I thought I already did that, but apparently not. I'll remove the complexity check and make it a lint as discussed in rust-lang/rfcs#2344 (comment)
4. emilyalbini

   added

   I-nominated

   on Apr 13, 2018
5. bors

   added a commit that references this issue on Apr 15, 2018

   Auto merge of #49947 - oli-obk:turing_complete_const_eval, r=nagisa

   ...

   8de5353
6. emilyalbini commented on Apr 17, 2018

   

   emilyalbini

   on Apr 17, 2018

   Last edited by emilyalbini

   MemberAuthor

   More actions

   The ostn02_phf fix is being backported to beta in #50027
7. urschrei commented on Apr 17, 2018

   

   urschrei

   on Apr 17, 2018

   Last edited by urschrei

   Contributor

   More actions

   Is that fix also in nightly? ostn02_phf is indeed deprecated, but its replacement (ostn15_phf) has an open issue which (as I just found out) is dependent on the fix – it currently only builds on stable macOS / Linux
8. emilyalbini commented on Apr 17, 2018

   

   emilyalbini

   on Apr 17, 2018

   Last edited by emilyalbini

   MemberAuthor

   More actions

   Is that fix also being backported to nightly?

   @urschrei that fix is already available in the nightly (master) branch, and the PR I linked backports it to beta. The only "problem" is, since Sunday no new nightlies were released because rls is broken. Once rls will be fixed new nightlies (with the regression fixed) will be released.
9. urschrei commented on Apr 17, 2018

   

   urschrei

   on Apr 17, 2018

   Contributor

   More actions

   @pietroalbini Thanks!
10. emilyalbini commented on Apr 20, 2018

    

    emilyalbini

    on Apr 20, 2018

    MemberAuthor

    More actions

    The ostn02_phf fix is backported to beta. What about out123-sys 0.2.1 @oli-obk?
11. oli-obk commented on Apr 20, 2018

    

    oli-obk

    on Apr 20, 2018

    Contributor

    More actions

    nightly PR in progress: #50072

    still needs a beta-accepted stamp

    👍React with 👍1Reacted by Emily Albini
12. emilyalbini

    removed

    I-nominated

    on Apr 26, 2018
13. emilyalbini commented on Apr 26, 2018

    

    emilyalbini

    on Apr 26, 2018

    MemberAuthor

    More actions

    Backport PR: #50248
14. nikomatsakis commented on Apr 26, 2018

    

    nikomatsakis

    on Apr 26, 2018

    Contributor

    More actions

    triage: P-high
15. nikomatsakis

    added

    P-highHigh priorityHigh priority

    on Apr 26, 2018
16. emilyalbini commented on Apr 26, 2018

    

    emilyalbini

    on Apr 26, 2018

    MemberAuthor

    More actions

    Backported to beta.
17. emilyalbini

    closed this as completedon Apr 26, 2018
18. RalfJung

    added

    A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)Area: Constant evaluation, covers all const contexts (static, const fn, ...)

    on Dec 1, 2024