Skip to content

Print message that clarifies some components are allowed to fail during build. #49952

Closed as not planned
Closed as not planned
Print message that clarifies some components are allowed to fail during build.#49952
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@dilyanpalauzov
dilyanpalauzov
opened on Apr 13, 2018
    Finished dev [unoptimized] target(s) in 0.0 secs
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 test from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
    Finished release [optimized] target(s) in 0.1 secs
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.1 secs
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage1 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
    Finished release [optimized] target(s) in 0.3 secs
    Finished release [optimized] target(s) in 0.3 secs
Assembling stage2 compiler (x86_64-unknown-linux-gnu)
Building stage2 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.1 secs
Copying stage2 std from stage2 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage2 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage2 test from stage2 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage2 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.3 secs
Copying stage2 rustc from stage2 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage2 tool cargo (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Building stage2 tool rls (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.1 secs
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Building stage2 tool clippy-driver (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Building stage2 tool rustfmt (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Building stage2 tool miri (x86_64-unknown-linux-gnu)
   Compiling miri v0.1.0 (file:///src/rustc-1.25.0-src/src/tools/miri)
error[E0464]: multiple matching crates for `log`
  --> tools/miri/miri/lib.rs:10:1
   |
10 | extern crate log;
   | ^^^^^^^^^^^^^^^^^
   |
   = note: candidates:
           crate `log`: /src/rustc-1.25.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblog-c8daedad
           crate `log`: /src/rustc-1.25.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblog-d3343004

error[E0463]: can't find crate for `log`
  --> tools/miri/miri/lib.rs:10:1
   |
10 | extern crate log;
   | ^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to 2 previous errors

error: Could not compile `miri`.

To learn more, run the command again with --verbose.


command did not execute successfully: "/src/rustc-1.25.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unk
expected success, got: exit code: 101


Build completed successfully in 0:00:24

Any ideas?

Activity

  1. oli-obk commented on Apr 13, 2018

    @oli-obk
    oli-obk
    on Apr 13, 2018
    Contributor

    Build completed successfully

    Miri failing to build is not an issue that breaks the build.

    See also #49933 which fixes miri

  2. dilyanpalauzov commented on Apr 13, 2018

    @dilyanpalauzov
    dilyanpalauzov
    on Apr 13, 2018
    Author

    As a matter of fact this happened also with 1.24.1: see last comment of #49052 .

    When will be there a 1.25.1 fixing this?

  3. oli-obk commented on Apr 14, 2018

    @oli-obk
    oli-obk
    on Apr 14, 2018
    Contributor

    I'm very confused. Why would it be relevant whether miri or clippy are built? They are not part of the distribution. I'm also not sure why you need a fix for a successful build (modulo miri). Can you elaborate?

    Are you doing distributions of rustc? If so, why do you need clippy and miri? They are nightly only.

    What commands are you invoking in order to get the above output?

  4. dilyanpalauzov commented on Apr 14, 2018

    @dilyanpalauzov
    dilyanpalauzov
    on Apr 14, 2018
    Author

    I do first ./configure --enable-ninja --enable-docs --enable-compiler-docs --enable-llvm-li nk-shared --enable-optimize --enable-full-bootstrap --enable-extended and then python /src/rustc-1.25.0-src/x.py build , where /src/rustc-1.25.0-src is the unpacked source code of https://static.rust-lang.org/dist/rustc-1.25.0-src.tar.gz.

    I don't know why clippy or mire are relevant, but the above command fails, and I want to install on my system Rust.

  5. oli-obk commented on Apr 14, 2018

    @oli-obk
    oli-obk
    on Apr 14, 2018
    Contributor

    The failures are not failing your build. The final statement says it was successful, even if the two tools fail. You can use the result just like you can use one where all tools successfully built.

    The "normal" way to install Rust is not by building it yourself, but by using rustup.

    We could emit a message that says that these builds are allowed to fail and that you can ignore the failure. Do you think that would help?

  6. dilyanpalauzov commented on Apr 14, 2018

    @dilyanpalauzov
    dilyanpalauzov
    on Apr 14, 2018
    Author

    I think that such a clarifying message, stating that the immediately preceding failures shall be ignored, will be very useful.

  7. oli-obk
    added
    A-diagnosticsArea: Messages for errors, warnings, and lints
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Apr 16, 2018
  8. XAMPPRocky
    added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Aug 27, 2018
  9. XAMPPRocky
    changed the title [-]Compiling rust 1.25.0 fails at stage 2[/-] [+]Print message that clarifies some components are allowed to fail during build.[/+] on Aug 27, 2018

  10. XAMPPRocky commented on Aug 27, 2018

    @XAMPPRocky
    XAMPPRocky
    on Aug 27, 2018
    Contributor

    Triage: I've updated the title of the issue to more accurately reflect the current state of the issue.

  11. jyn514 commented on Feb 3, 2023

    @jyn514
    jyn514
    on Feb 3, 2023
    Member

    This should no longer be relevant now that toolstate no longer exists: #79249

  12. jyn514
    closed this as not plannedon Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions