Repository navigation
Rename CodeMap/FileMap to SourceMap/SourceFile. #51574
Description
Activity
I can take this up.
Reacted by Eduard-Mihai BurtescuWhat about structs like
FileMapAndLine?@abhijeetbhagat
SourceFileAndLinelooks fine to me.should the module codemap also be renamed?
Yeah, any combination of the words "code" and "map" should.
Right. Changing that too.
- added a commit that references this issue
on Aug 19, 2018 With the merge, it's unclear to me whether this is an older issue that needs closing, or if there is more work to do. A quick search seems to show the following occurences still:
MalformedForCodemapandMalformedCodemapPositionsinsrc/libsyntax_pos/lib.rsandsrc/libsyntax/source_map.rspub use self::caching_codemap_view::CachingSourceMapViewinsrc/librustc/ich/mod.rsStableFilemapIdinsrc/libsyntax/source_map.rs
If this issue is still considered open, does that reflect that that these should be renamed as well?
MalformedForCodemap->MalformedForSourceMapMalformedCodemapPositions->MalformedSourceMapPositionsself::caching_codemap_view->self::caching_source_map_viewStableFilemapId->StableSourceFileId
Reacted by dlavati- added a commit that references this issue
on Oct 30, 2018 I came across over this instance of
cmtoday:
rust/src/librustc_errors/lib.rs
Line 149 in e6ec0d1
So we might need to do another pass just for easier to miss things like
cm.
The name
FileMapalways seemed a bit jarring, and I think this would be an improvement.cc @nikomatsakis @nrc