ICE on loop {|_: [_; continue]| {}}

The following code ICEs on nightly, stable and beta:

fn main() {
    loop {|_: [_; continue]| {}}
}

The ICE message is:

error: internal compiler error: librustc_mir/hair/cx/expr.rs:551: invalid loop id for continue: not inside loop scope

As of filing this bug, PR #51731 does not fix it. If I apply it, I'm getting:

error: internal compiler error: librustc_mir/build/scope.rs:552: no enclosing breakable scope found
  --> $DIR/issue-XXXX.rs:12:19
   |
LL |     loop {|_: [_; continue]| {}}
   |                   ^^^^^^^^

Counterintuitively, this should probably compile successfully. It's not surprising that it's not working, though: it's a really weird edge case. I'll look into it.

I don't think it should compile successfully. The continue is in an array length constant expression inside the closure's signature. Therefore, it's not part of the loop body and should cause an "continue outside of loop" error.

I feel perhaps control-flow should just not be allowed inside type-level constants like this. That seems like the most logical decision. In which case, we should just add a new error for this.

Edit: Just saw @rkruppe's comment. I agree, though I'm not sure there's precedent for that or not? Is there an existing error we can make us of?

As I said, I believe this is a plain old "continue outside of loop" errors. The continue token is lexically within the loop { ... }, but it's not part of the loop body, so it's invalid without even considering that it's supposed to be a constant. It's morally the same as loop { fn foo() { continue } }.

What about the break version?
Not sure if the fix is applied in the latest nightly, but this still ICE's:
#51707

Rewritting it using a loop {} instead of while:

fn main() {
    loop {
        |_: [_; break] | {}
    }
}

@DutchGhost

@DutchGhost that's fixed by @varkor 's PR #51731 . The fix is not in nightly yet, not even merged. I've applied the PR locally in order to test whether the loop {loop {|_: [_; continue]| {}} } bug still exists.

It would probably make sense if @varkor would also fix the break version right away.

Rollup merge of rust-lang#51967 - varkor:const-body-break-continue, r…

Auto merge of #51967 - varkor:const-body-break-continue, r=estebank

Navigation Menu

Repository navigation

ICE on loop {|_: [_; continue]| {}} #51761

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ICE on loop {|_: [_; continue]| {}} #51761

Description

Activity

varkor commented on Jun 25, 2018

hanna-kruppe commented on Jun 25, 2018

varkor commented on Jun 25, 2018

hanna-kruppe commented on Jun 25, 2018

DutchGhost commented on Jun 25, 2018

est31 commented on Jun 25, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions