Skip to content

Tracking issue for RFC 2296, Option::replace #51998

Closed
Closed
Tracking issue for RFC 2296, Option::replace#51998
Labels
B-RFC-implementedBlocker: Approved by a merged RFC and implemented but not stabilized.B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@Centril
Centril
opened on Jul 2, 2018

This is a tracking issue for the RFC "Add Option::replace to the core library" (rust-lang/rfcs#2296).

Steps:

Unresolved questions:

None

Activity

  1. Centril
    added
    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.
    T-libs-api[DEPRECATED; DO NOT USE]
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Jul 2, 2018
  2. kennytm
    added a commit that references this issue on Jul 12, 2018

    Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi

    e2683f2
  3. Mark-Simulacrum
    added a commit that references this issue on Jul 13, 2018

    Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi

    20176fe
  4. kennytm
    added a commit that references this issue on Jul 13, 2018

    Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi

    a2c3713
  5. varkor
    added
    B-RFC-implementedBlocker: Approved by a merged RFC and implemented but not stabilized.
    and removed
    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.
    on Jul 29, 2018
  6. Centril
    added
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    on Sep 18, 2018

  7. Centril commented on Sep 18, 2018

    @Centril
    Centril
    on Sep 18, 2018
    ContributorAuthor

    cc @SimonSapin this has baked in nightly for roughly 9.5 weeks; should we stabilize?

  8. SimonSapin commented on Sep 18, 2018

    @SimonSapin
    SimonSapin
    on Sep 18, 2018
    Contributor

    Looks good to me.

    @rfcbot fcp merge

  9. rfcbot commented on Sep 18, 2018

    @rfcbot
    rfcbot
    on Sep 18, 2018

    Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

    No concerns currently listed.

    Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  10. rfcbot
    added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Sep 18, 2018

  11. rfcbot commented on Sep 19, 2018

    @rfcbot
    rfcbot
    on Sep 19, 2018

    🔔 This is now entering its final comment period, as per the review above. 🔔

  12. rfcbot
    removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Sep 19, 2018

  13. rfcbot commented on Sep 29, 2018

    @rfcbot
    rfcbot
    on Sep 29, 2018

    The final comment period, with a disposition to merge, as per the review above, is now complete.

  14. rfcbot
    added
    finished-final-comment-periodThe final comment period is finished for this PR / Issue.
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Sep 29, 2018

  15. Centril commented on Oct 7, 2018

    @Centril
    Centril
    on Oct 7, 2018
    ContributorAuthor

    @Kerollmops would you be willing to write up a stabilization PR?

  16. Kerollmops commented on Oct 7, 2018

    @Kerollmops
    Kerollmops
    on Oct 7, 2018
    Contributor

    Yes, I will do that !

  17. emilyalbini
    added 2 commits that reference this issue on Oct 9, 2018

    Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…

    2f3569b

    Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…

    12db9d2

  18. Centril commented on Oct 31, 2018

    @Centril
    Centril
    on Oct 31, 2018
    ContributorAuthor

    I believe there's nothing more left to do; closing therefore.

  19. Centril
    closed this as completedon Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-RFC-implementedBlocker: Approved by a merged RFC and implemented but not stabilized.B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions