Skip to content

Deduplicate rustc-ap-syntax in the RLS #53006

Closed
Closed
Deduplicate rustc-ap-syntax in the RLS#53006

Description

@alexcrichton
alexcrichton
opened on Aug 2, 2018

As of #52919 we'll be updating to a version of the RLS which depends on racer which depends on rustc-ap-syntax. Unfortunately we're bringing in two different versions of rustc-ap-syntax, 209 and 211, right now.

These should be deduplicated as they take a good deal of time to build on CI, and then we should also add a tidy check which ensures that there's only one version of rustc-ap-syntax in our workspace.

cc @nrc

Activity

  1. alexcrichton
    added
    A-build
    on Aug 2, 2018

  2. alexcrichton commented on Aug 2, 2018

    @alexcrichton
    alexcrichton
    on Aug 2, 2018
    MemberAuthor

    I've sent a PR to update racer as part of racer-rust/racer#915

  3. nrc commented on Aug 8, 2018

    @nrc
    nrc
    on Aug 8, 2018
    Member

    This is fixed by #53141

  4. alexcrichton
    added a commit that references this issue on Aug 9, 2018

    Deny future duplication of rustc-ap-syntax

    6c7473d
  5. GuillaumeGomez
    added a commit that references this issue on Aug 12, 2018

    Rollup merge of rust-lang#53210 - alexcrichton:deny-rustc-syntax, r=nrc

    0903b18
  6. bors
    closed this as completedin #53210on Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions