Repository navigation
Update rls-data and rls-analysis versions #53440
Description
Activity
added 3 commits that reference this issue on Aug 17, 2018
I guess updating it in the compiler before rls was the way to go? I submitted rust-lang/rls#973 but never got an answer about how to do this. Thanks for doing this!
I guess updating it in the compiler before rls was the way to go?
I've never done it before, but that's what the documentation seems to imply. AFAICT step 1 is land it in rustc, step is land the RLS change, and step 3 is update the submodule in rustc to point to the new RLS.
but never got an answer about how to do this
oh crap, sorry!
step 1 is land it in rustc, step is land the RLS change, and step 3 is update the submodule in rustc to point to the new RLS
That's correct.
added a commit that references this issue on Aug 23, 2018
This is done.
I'd like to bump rls-analysis and rls-data to the latest available versions (0.16 and 0.18, respectively). Specifically to pick up the changes from rust-dev-tools/rls-analysis#147. It looks like this will need the three-step update process described at https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#breaking-tools-built-with-the-compiler. I will attempt to create the appropriate patches.
/cc @nrc