Repository navigation
Disallow attribute macros named cfg #53531
Description
Activity
I think this would be a good issue for mentoring. I'm happy to help out.
The
testattribute seems to be similarly ignored.I could give it a go. As a first time contributor please be patient 😉
I'd check it during name resolution instead, so you can do
#[foo::cfg(...)]just fine, but not import it unqualified.I have a PR in progress that resolves the penultimate item in #50911 (comment) and passes all attributes through name resolution, that includes
cfgas well.(Disallowing proc macros named
cfgis both too much -#[foo::cfg]is ok, and not enough -use my_non_cfg_attr_macro as cfg;).Reacted by Eduard-Mihai Burtescu and djrenren@petrochenkov Ah yeah I hadn't thought about that! That's awesome.
- added a commit that references this issue
on Sep 3, 2018 - added a commit that references this issue
on Sep 11, 2018
#[cfg()]runs before name resolution so no proc macro attribute namedcfgcould ever be called. We should make this a hard error at the declaration site to protect people from this confusion.