You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
unused_extern_crates lint trigged after return of extern crate syntax for non-Cargo crates (alloc, etc.) #54381
Fallout from #54116, which fixed the syntax for imports from extern crates, a temporary solution to #53166.
This code:
externcrate alloc;
Leads to an unused_extern_crates lint failure.
error: `extern crate` is not idiomatic in the new edition
--> bla/src/lib.rs:31:1
|
31 | extern crate alloc;
| ^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
|
note: lint level defined here
--> bla/src/lib.rs:15:5
|
15 | unused,
| ^^^^^^
= note: #[deny(unused_extern_crates)] implied by #[deny(unused)]
Activity
alexcrichton commentedon Sep 28, 2018
@eddyb was #54116 merged without a solution of what to do for this in Cargo?
eddyb commentedon Sep 28, 2018
We should at least fix the lint so it doesn't trigger in the cases where
use foo;doesn't work.cc @rust-lang/lang
Auto merge of #54650 - eddyb:no-extern's-land, r=alexcrichton