[1.30 beta] Test suite of the jemalloc-ctl crate is failing

[emilyalbini]

This is not a spurious failure (the test output is consistent between runs), but we need to investigate why this is happening.

• jemalloc-ctl 0.2.0 regressed from stable to beta (build log) cc @sfackler

[sfackler]

Those errors seem to imply that global allocator registration may have broken?

[sfackler]

It seems like it may specifically be a problem with rustdoc tests - a normal library test passes as expected.

[pnkfelix]

Bisection over nightly builds indicates that bug was injected between nightly-2018-08-06-x86_64-unknown-linux-gnu (73c7873) and nightly-2018-08-14-x86_64-unknown-linux-gnu (d5a448b).

In the details block are the bors commits from that range:

Details

% git log --author bors 73c7873..d5a448b --format=oneline

• d5a448b Auto merge of Fix a few regressions from enabling macro modularization #53270 - petrochenkov:macuse-regr, r=alexcrichton

• a78ae85 Auto merge of Avoid many allocations for CStrings during codegen. #53161 - michaelwoerister:cstrings, r=wesleywiser

• 147ca2d Auto merge of Update RLS #53238 - nrc:update, r=kennytm

• ab93561 Auto merge of Emit error for pattern arguments in trait methods #53051 - varkor:trait-method-pattern-arguments-error, r=petrochenkov

• 5a0d296 Auto merge of Rollup of 15 pull requests #53297 - GuillaumeGomez:rollup, r=GuillaumeGomez

  • Update compiler test documentation #52955 (Update compiler test documentation)
  • Don't collect() when size_hint is useless #53019 (Don't collect() when size_hint is useless)
  • Consider changing assert! to debug_assert! when it calls visit_with #53025 (Consider changing assert! to debug_assert! when it calls visit_with)
  • Remove explicit returns where unnecessary #53059 (Remove explicit returns where unnecessary)
  • Add aarch64-unknown-netbsd target #53165 ( Add aarch64-unknown-netbsd target)
  • Deny future duplication of rustc-ap-syntax #53210 (Deny future duplication of rustc-ap-syntax)
  • A few cleanups for rustc_data_structures #53223 (A few cleanups for rustc_data_structures)
  • [nll] enable feature(nll) on various crates for bootstrap: part 4 #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4)
  • Add let keyword doc #53231 (Add let keyword doc)
  • Add individual documentation for <integer>.swap_bytes/.reverse_bits #53240 (Add individual documentation for .swap_bytes/.reverse_bits)
  • Remove unwanted console log #53253 (Remove unwanted console log)
  • Show that Command can be reused and remodified #53264 (Show that Command can be reused and remodified)
  • Fix styles #53267 (Fix styles)
  • Add links to std::char::REPLACEMENT_CHARACTER from docs. #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.)
  • wherein we suggest float for integer literals where a float was expected #53283 (wherein we suggest float for integer literals where a float was expected)

• 0aa8d03 Auto merge of optimize redundant borrows and escaping paths in NLL  #53177 - nikomatsakis:nll-redundant-borrows-and-escaping-values, r=pnkfelix

• a77dfcc Auto merge of NLL says something "does not live long enough" when talking about a (thread-local) static #53131 - davidtwco:issue-52663-thread-local-static, r=nikomatsakis

• f6d43ed Auto merge of region error messages involving impls are confusing  #53124 - davidtwco:issue-52742, r=nikomatsakis

• db1acaa Auto merge of Cleanup to librustc::session and related code #53073 - Mark-Simulacrum:data-structures, r=pnkfelix

• fb65d75 Auto merge of Add help message for missing IndexMut impl  #52788 - LukasKalbertodt:improve-index-mut-error, r=estebank

• 8958ed6 Auto merge of Rollup of 15 pull requests #53216 - kennytm:rollup, r=kennytm

  • Avoid unnecessary pattern matching against Option and Result #52773 (Avoid unnecessary pattern matching against Option and Result)
  • Fix doc link (again) #53082 (Fix doc link (again))
  • Automatically expand section if url id point to one of its component #53094 (Automatically expand section if url id point to one of its component)
  • atomic ordering docs #53106 (atomic ordering docs)
  • Account for --remap-path-prefix in save-analysis #53110 (Account for --remap-path-prefix in save-analysis)
  • NetBSD: fix signedess of char #53116 (NetBSD: fix signedess of char)
  • Whitelist wasm32 simd128 target feature #53179 (Whitelist wasm32 simd128 target feature)
  • Suggest comma when missing in macro call #53183 (Suggest comma when missing in macro call)
  • Add individual docs for rotate_{left, right} #53207 (Add individual docs for rotate_{left, right})
  • [nll] enable feature(nll) on various crates for bootstrap #53211 ([nll] enable feature(nll) on various crates for bootstrap)
  • [nll] enable feature(nll) on various crates for bootstrap: part 2 #53214 ([nll] enable feature(nll) on various crates for bootstrap: part 2)
  • Slightly refactor syntax_ext/format #53215 (Slightly refactor syntax_ext/format)
  • inline some short functions #53217 (inline some short functions)
  • [nll] enable feature(nll) on various crates for bootstrap: part 3 #53219 ([nll] enable feature(nll) on various crates for bootstrap: part 3)
  • A few cleanups for rustc_target #53222 (A few cleanups for rustc_target)

• b73535f Auto merge of Apply some fixes to cross-language LTO (especially when targeting MSVC) #53031 - michaelwoerister:cross-lto, r=alexcrichton

• fbb6275 Auto merge of clarify partially initialized Mutex issues #53108 - RalfJung:mutex, r=alexcrichton

• 76b69a6 Auto merge of Fix improper_ctypes lint for individual foreign items #53100 - VPashkov:issue-52456-improper_ctypes, r=eddyb

• 80caa7f Auto merge of Fixes #53119. #53186 - mikhail-m1:master, r=nikomatsakis

• 62e4e08 Auto merge of Remove an overly pedantic and wrong assertion #53163 - oli-obk:const_prop_ice, r=nikomatsakis

• 376b60d Auto merge of Update clippy submodule #53192 - oli-obk:clippyup, r=kennytm

• 63fe441 Auto merge of [NLL] Use span of the closure args in free region errors #53088 - matthewjasper:closure-region-spans, r=nikomatsakis

• ebe8df4 Auto merge of Make IpvXAddr::new const fns and the well known addresses associated constants #52872 - faern:use-modern-alignment-libc, r=TimNN

• ffb09df Auto merge of resolve: Support custom attributes when macro modularization is enabled #53053 - petrochenkov:custattr, r=alexcrichton

• 52c785b Auto merge of Update RLS, Rustfmt, and Clippy #53141 - nrc:update, r=nrc

• 26d7b64 Auto merge of rustc: Tweak visibility of some lang items  #52993 - alexcrichton:fix-some-vis, r=michaelwoerister

• 3f4f18f Auto merge of Suggest comma when writing println!("{}" a); #52397 - estebank:println-comma, r=oli-obk

• e90dc6f Auto merge of Add HirId to VisibilityKind::Restricted #52911 - Mark-Simulacrum:visibility-hirid, r=oli-obk

• ccb550f Auto merge of revert #52991 #53109 - nikomatsakis:nll-escaping-into-return-revert, r=nikomatsakis

• 39e9516 Auto merge of Place unions, pointer casts and pointer derefs behind extra feature gates #51990 - oli-obk:unstable_union, r=nikomatsakis

• 18925de Auto merge of Rollup of 10 pull requests #53150 - kennytm:rollup, r=kennytm

  • Remove some unused method arguments from typeck #52885 (Remove some unused method arguments from typeck)
  • cleanup: Remove Def::GlobalAsm #52886 (cleanup: Remove Def::GlobalAsm)
  • Building librustc_codegen_llvm in a separate directory #53028 (Building librustc_codegen_llvm in a separate directory)
  • fixed broken links to char #53052 (fixed broken links to char)
  • Change rustdoc style so fully qualified name does not overlap src link #53060 (Change rustdoc style so fully qualified name does not overlap src link)
  • Rename Executor trait to Spawn #53068 (Rename Executor trait to Spawn)
  • Enable macros to pass $:literal to another macro #53093 (Enable macros to pass $:literal to another macro)
  • Remove references to StaticMutex which got removed a while ago #53107 (Remove references to StaticMutex which got removed a while ago)
  • Rust 2018: Disable catch_expr, not targeted for 2018 edition #53135 (Rust 2018: Disable catch_expr, not targeted for 2018 edition)
  • set emit_debug_gdb_scripts: false for riscv32imac-unknown-none target #53139 (set emit_debug_gdb_scripts: false for riscv32imac-unknown-none target)

• 9e472c2 Auto merge of Closes #52413: Provide structured suggestion instead of label #52450 - PramodBisht:issue/52413, r=estebank

• 11a9024 Auto merge of Make globals with private linkage unnamed. Fixes #50862. #51007 - AstralSorcerer:master, r=nagisa

• f9b9b6e Auto merge of More debugging for travis shutting down #53134 - alexcrichton:tweak-travis, r=Mark-Simulacrum

• 45a9d41 Auto merge of Extract impl_header_lifetime_elision out of in_band_lifetimes #53016 - scottmcm:impl-header-lifetime-elision, r=nikomatsakis

• cf84056 Auto merge of Disable some nice region errors in NLL mode. #53115 - davidtwco:issue-52739, r=nikomatsakis

• b239743 Auto merge of Add errors for unknown, stable and duplicate feature attributes #52644 - varkor:lib-feature-gate-2, r=withoutboats

• 4b8089d Auto merge of Fix ICE when rustdoc encounters certain usages of HRTBs #52990 - Aaron1011:fix/rustdoc-auto-trait-static, r=eddyb

• 78ec12d Auto merge of Fix NLL migration mode so that reports region errors when necessary. #53045 - pnkfelix:issue-53026-migrate-never-looser-than-ast-borrowck, r=estebank

• 7c98d2e Auto merge of dead-code lint: say "constructed" for structs #52332 - zackmdavis:dead_code_lint_should_say_2_electric_boogaloo, r=pnkfelix

• aa1e6db Auto merge of make everybody_loops preserve item declarations #53002 - QuietMisdreavus:brother-may-i-have-some-loops, r=pnkfelix

• e9fa9f5 Auto merge of data_structures: make TinyList more readable and optimize remove(_) #52997 - llogiq:tiny-list-opt, r=varkor

[pnkfelix]

Okay I bisected this and identified the bug as being injected by #52993

[pnkfelix]

Adding @alexcrichton to the assignee list in case they have some special insight into how best to address it. (But, as I noted on #52993, I am hoping we can get away with just undoing one small part of that PR, rather than backing out the whole thing, which seems like it might cause more trouble than it would resolve)

[pnkfelix]

(also, tagging with both T-compiler and T-libs for now, though either team is free to untag the other if they want to take responsibility for resolving this.)