Skip to content

Cargo warning during x.py build: "the cargo feature edition is now stable" #54697

Closed
#54916
Closed
Cargo warning during x.py build: "the cargo feature edition is now stable"#54697
#54916

Description

@RalfJung
RalfJung
opened on Sep 30, 2018

Plenty of lines like the following are printed during a build:

warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest

This is likely caused by these:

src/tools/rls/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/rustc_tools_util/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/clippy_lints/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/clippy_dev/Cargo.toml
1:cargo-features = ["edition"]

Activity

  1. matthiaskrgr commented on Sep 30, 2018

    @matthiaskrgr
    matthiaskrgr
    on Sep 30, 2018
    Member

    The clippy ones are already fixed upstream: rust-lang/rust-clippy#3242

  2. cuviper commented on Oct 1, 2018

    @cuviper
    cuviper
    on Oct 1, 2018
    Member

    ISTR that 1.30-beta was only preview-stabilizing edition stuff, but that they'll be unstable in the 1.30 release. So when the current master branch forks off as 1.31-beta, it will still need to bootstrap with that 1.30 stable.

    But if cargo is going to keep edition stable in 1.30, then we can go ahead and nuke those.

  3. RalfJung commented on Oct 8, 2018

    @RalfJung
    RalfJung
    on Oct 8, 2018
    MemberAuthor

    The clippy fix has landed in rustc. RLS also has a fix at rust-lang/rls#1074. What would it take to get that into rustc?

  4. matthiaskrgr commented on Oct 8, 2018

    @matthiaskrgr
    matthiaskrgr
    on Oct 8, 2018
    Member

    Needs submodule update, I can do that this afternoon

  5. Mark-Simulacrum
    added a commit that references this issue on Oct 11, 2018

    Rollup merge of rust-lang#54916 - matthiaskrgr:submodules_update, r=o…

    8ce7ce2
  6. bors
    added a commit that references this issue on Oct 11, 2018

    Auto merge of #54916 - matthiaskrgr:submodules_update, r=oli-obk

    8e9aa14
  7. matthiaskrgr
    added a commit that references this issue on Oct 13, 2018

    submodules: update rls from 15d4d4a to 440a985

    2e84e9c
  8. bors
    added a commit that references this issue on Oct 13, 2018

    Auto merge of #54916 - matthiaskrgr:submodules_update, r=oli-obk

    4699283
  9. bors
    closed this as completedin #54916on Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions