Inference regression in nightly affecting Pin::set and futures

futures-util-preview does not build on the current nightly because the compiler is unable to infer that a type is Sized. This is a regression in the latest nightly.

The line that errors is here.

Error message:

error[E0277]: the size for values of type `<&mut future::maybe_done::MaybeDone<Fut> as std::ops::Deref>::Target` cannot be known at compilation time
   --> futures-util/src/future/maybe_done.rs:110:9
    |
110 |         Pin::set(self, MaybeDone::Done(res));
    |         ^^^^^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `<&mut future::maybe_done::MaybeDone<Fut> as std::ops::Deref>::Target`

Relevant commits: edaac35...6acbb5b

cc rust-lang/futures-rs#1350

Minimized example without Pin and external dependencies:

use std::ops::{Deref, DerefMut};

fn foo<P>(_value: <P as Deref>::Target)
where
    P: DerefMut,
    <P as Deref>::Target: Sized,
{}

fn main() {
    foo::<&mut u32>(2);
}

Playground.

@qnighy

Possibly caused by #56045

cc @qnighy

Enabling the unsized_locals feature fixes this, so this is being caused by the gate here.

Perhaps do I need some normalization before doing deferred Sizedness checking?

triage. This is now a stable-to-beta regression. P-high.

@nikomatsakis

assigning to @nikomatsakis to either r+ PR #56282, come up with a new fix, or delegate those options to someone else.

Auto merge of #56282 - qnighy:additional-sizedness-fix, r=nikomatsakis

Navigation Menu

Repository navigation

Inference regression in nightly affecting `Pin::set` and futures #56237

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Inference regression in nightly affecting Pin::set and futures #56237

Description

Activity

hcpl commented on Nov 26, 2018

oli-obk commented on Nov 26, 2018

cramertj commented on Nov 26, 2018

qnighy commented on Nov 27, 2018

pnkfelix commented on Dec 6, 2018

pnkfelix commented on Dec 6, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Inference regression in nightly affecting `Pin::set` and futures #56237