Skip to content

Up to 7% regression in recent rollup #57115

Closed
Closed
Up to 7% regression in recent rollup#57115
Labels
I-compilememIssue: Problems and improvements with respect to memory usage during compilation.I-compiletimeIssue: Problems and improvements with respect to compile times.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

Description

@alexcrichton
alexcrichton
opened on Dec 25, 2018

Noticed here it looks like something in that rollup has caused a blanket regression in compile time instruction counts while also simultaneously improving memory. The current hypothesis is that #56986 is incorrect and disabled jemalloc entirely.

Another hypothesis is that #56944 had a really weird effect on the build.

In any case, we should investigate!

Activity

  1. alexcrichton
    added
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    on Dec 25, 2018
  2. Centril
    added
    I-slowIssue: Problems and improvements with respect to performance of generated code.
    I-compilememIssue: Problems and improvements with respect to memory usage during compilation.
    I-compiletimeIssue: Problems and improvements with respect to compile times.
    and removed
    I-slowIssue: Problems and improvements with respect to performance of generated code.
    on Dec 25, 2018

  3. alexcrichton commented on Jan 2, 2019

    @alexcrichton
    alexcrichton
    on Jan 2, 2019
    MemberAuthor

    I believe this should be fixed in #57287

  4. bors
    added a commit that references this issue on Jan 2, 2019

    Auto merge of #57287 - alexcrichton:fix-jemalloc, r=<try>

    3550c27
  5. nagisa
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 3, 2019
  6. bors
    added a commit that references this issue on Jan 6, 2019

    Auto merge of #57287 - alexcrichton:fix-jemalloc, r=nikomatsakis

    af2c159
  7. bors
    closed this as completedin #57287on Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    I-compilememIssue: Problems and improvements with respect to memory usage during compilation.I-compiletimeIssue: Problems and improvements with respect to compile times.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions