Skip to content

type_flags method on ty::Const is a footgun #59209

Closed
#59178
Closed
type_flags method on ty::Const is a footgun#59209
#59178
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Description

@oli-obk
oli-obk
opened on Mar 15, 2019

Related discussion in #59178 (comment)

Basically the type_flags method should be manually inlined into its use sites (and operations that are happening twice should be deduplicated)

Activity

  1. oli-obk
    added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
    on Mar 15, 2019
  2. bors
    closed this as completedin #59178on Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions