Skip to content

rls no longer builds after rust-lang/rust#58140 #59218

Closed

Description

@rust-highfive

Hello, this is your friendly neighborhood mergebot.
After merging PR #58140, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @eddyb, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @nikomatsakis, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Mar 15, 2019
  2. kennytm commented on Mar 15, 2019

    @kennytm
    Member

    Error is caused by clippy-lints dependency.

    [01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
    [01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:104:10
    [01:26:39]     |
    [01:26:39] 104 | impl ty::item_path::ItemPathBuffer for AbsolutePathBuffer {
    [01:26:39]     |          ^^^^^^^^^ could not find `item_path` in `ty`
    [01:26:39] 
    [01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
    [01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:105:33
    [01:26:39]     |
    [01:26:39] 105 |     fn root_mode(&self) -> &ty::item_path::RootMode {
    [01:26:39]     |                                 ^^^^^^^^^ could not find `item_path` in `ty`
    [01:26:39] 
    [01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
    [01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:106:30
    [01:26:39]     |
    [01:26:39] 106 |         const ABSOLUTE: &ty::item_path::RootMode = &ty::item_path::RootMode::Absolute;
    [01:26:39]     |                              ^^^^^^^^^ could not find `item_path` in `ty`
    [01:26:39] 
    [01:26:39] error[E0433]: failed to resolve: could not find `item_path` in `ty`
    [01:26:39]    --> src/tools/clippy/clippy_lints/src/utils/mod.rs:106:57
    [01:26:39]     |
    [01:26:39] 106 |         const ABSOLUTE: &ty::item_path::RootMode = &ty::item_path::RootMode::Absolute;
    [01:26:39]     |                                                         ^^^^^^^^^ could not find `item_path` in `ty`
    [01:26:39] 
    [01:26:40] error: aborting due to 4 previous errors
    
  3. mati865 commented on Mar 15, 2019

    @mati865
    Member

    I'm on it.

  4. eddyb commented on Mar 15, 2019

    @eddyb
    Contributor

    @mati865 I would like to review the resulting PR, if you don't mind. You can also PM me (on IRC/Discord) if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions