Skip to content

Tracking issue for Iterator::is_partitioned #62544

Open
Open
Tracking issue for Iterator::is_partitioned#62544
Labels
A-iteratorsArea: IteratorsB-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Description

@cuviper
cuviper
opened on Jul 9, 2019
/// Checks if the elements of this iterator are partitioned according to the given predicate,
/// such that all those that return `true` precede all those that return `false`.
fn is_partitioned<P>(mut self, mut predicate: P) -> bool
where
    Self: Sized,
    P: FnMut(Self::Item) -> bool,

feature = "iter_is_partitioned"

ref: #62278

Unresolved questions

  • Do we want this function at all? (Motivating use cases would be useful.)
  • Would is_sorted_by_key already cover all use cases?

Activity

  1. cuviper
    added
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    T-libs-api[DEPRECATED; DO NOT USE]
    on Jul 9, 2019
  2. KodrAus
    added
    A-iteratorsArea: Iterators
    I-libs-radarLibs issues that are tracked on the team's radar.
    on Jul 30, 2020

  3. TheWastl commented on Dec 15, 2020

    @TheWastl
    TheWastl
    on Dec 15, 2020
    Contributor

    Is there anything blocking this from stabiilization?

  4. cuviper commented on Dec 16, 2020

    @cuviper
    cuviper
    on Dec 16, 2020
    MemberAuthor

    No blocker that I know of. There's some question about the related partition_in_place, but is_partitioned is straightforward.

  5. m-ou-se commented on Dec 20, 2020

    @m-ou-se
    m-ou-se
    on Dec 20, 2020
    Member

    Comments from the stabilization PR:

    I've looked at the various linked issues but didn't see any motivating use cases for this routine.

    Thinking a bit more about this, I suppose that pretty much all use cases of this function are also covered by is_sorted_by_key.

    I've added this as an unresolved question above.

  6. jayaddison commented on Sep 21, 2021

    @jayaddison
    jayaddison
    on Sep 21, 2021
    Contributor

    (arrived here thanks to an initially unrelated curiosity re: iterator::partition (specifically, that it only provides binary partitions))

    About use cases: one could be to aid (perhaps semi-automated) porting of existing C++ code that uses stdlib partition (which maps to partition_in_place in Rust, as I understand it?) in combination with stdlib is_partitioned.

    I'm a very small Rustacean so I don't know if I understand correctly, but it does seem like all use cases for is_partitioned could theoretically be translated to an implementation in terms of is_sorted_by_key -- but that doing that could require careful sort order / partition function handling, and perhaps more care than automated porting tools could achieve easily / performantly. Basically I think they'd tend to rewrite it as a a check for is_sorted_by ( negation ( partition_func ) ) (because the left-side partition is the true values).

    Current implementation notes: is_sorted_by_key performs a (lazy) map across the iterator whereas the current is_partitioned implementation short-circuits by applying all until failure, and then any for remaining elements. Those seem to both have O(n) worst-case?

  7. siebenHeaven commented on Dec 9, 2023

    @siebenHeaven
    siebenHeaven
    on Dec 9, 2023

    Can this be extended to return an Option<usize> that would be Some(partition_point) if it is partitioned and None if it's not?

  8. evlogiy commented on Apr 1, 2024

    @evlogiy
    evlogiy
    on Apr 1, 2024

    I conducted some testing, and the current implementation (which is quite neat in my opinion), iter.all(predicate) || !iter.any(predicate), is about 2.5 times faster than the implementation using iter.is_sorted_by_key(|x| !predicate(x)). I conducted this testing in response to @jayaddison's comment, although I must admit that I somewhat lost track of the original purpose in the process.

    While I feel somewhat indifferent towards the is_partitioned() function, I would be interested in seeing something similar to what @siebenHeaven suggests implemented. However, I believe the function should be named differently; perhaps find_partition_index would be more suitable?

    Is there a similar suggestion already in progress? If so, could you assist me in locating it? If not, would you be able to point me to how I can create a new one?

  9. blyxyas commented on May 4, 2025

    @blyxyas
    blyxyas
    on May 4, 2025
    Member

    @Areczek94 Did you mean to give your opinion on "Do we want this function at all?" Seems that your comment is exactly the same as the original post but with that option marked on.

    For future reference, you can just say that you think that this function is worth it, and make your argument after thinking about it for a while. No need to copy-paste the original post.

  10. clarfonthey
    added
    T-libsRelevant to the library team, which will review and decide on the PR/issue.
    and removed
    T-libs-api[DEPRECATED; DO NOT USE]
    on Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-iteratorsArea: IteratorsB-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libsRelevant to the library team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions