Avoid recording unnameable `extern crate` aliases in diagnostic metadata by raushan728 · Pull Request #158997 · rust-lang/rust

raushan728 · 2026-07-09T06:45:13Z

the root cause was that block scoped extern crate aliases were still being recorded as ExternCrateSource::Extern(def_id). later, diagnostics reused that metadata and attempted to print paths through those aliases, producing unnameable paths such as crate::_::_my_crate.

this change detects extern crate items whose DefPath passes through a value namespace (for example inside functions or const blocks) and records them as ExternCrateSource::Path instead. diagnostics then fall back to the crate name rather than an unnameable alias.

Closes #153459

rustbot · 2026-07-09T06:45:18Z

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

…tion

…Source::Path` Use the `DefPath` to determine whether an `extern crate` item is globally nameable. `extern crate` items nested inside value namespaces cannot be referred to by a stable path outside their enclosing scope. Record them as `ExternCrateSource::Path` instead of `ExternCrateSource::Extern` so later path resolution does not reconstruct unnameable paths.

rustbot · 2026-09-27T10:35:26Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

raushan728 · 2026-09-27T10:38:41Z

@rustbot reroll

nnethercote · 2026-09-27T23:49:09Z

@cjgillot's availability recently dropped. I'm not a good reviewer for this, I think the best alternative is probably:

r? @petrochenkov

rust-bors · 2026-09-28T15:29:37Z

📌 Commit 2e4b8e5 has been approved by petrochenkov

It is now in the queue for this repository.

…henkov Avoid recording unnameable `extern crate` aliases in diagnostic metadata the root cause was that block scoped `extern crate` aliases were still being recorded as `ExternCrateSource::Extern(def_id)`. later, diagnostics reused that metadata and attempted to print paths through those aliases, producing unnameable paths such as `crate::_::_my_crate`. this change detects `extern crate` items whose `DefPath` passes through a value namespace (for example inside functions or `const` blocks) and records them as `ExternCrateSource::Path` instead. diagnostics then fall back to the crate name rather than an unnameable alias. Closes rust-lang#153459

…uwer Rollup of 15 pull requests Successful merges: - #158936 (Add `std::fs::{Home|Media}Dirs`) - #129036 (Additional NonZero conversions) - #158997 (Avoid recording unnameable `extern crate` aliases in diagnostic metadata) - #161015 (Stabilize `funnel_shifts` (including `const`)) - #161712 (Stabilize `Result::into_{ok,err}`) - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #162655 (next solver: prefer to select impl candidates over global where-clause candidates) - #162862 (Fix intra doc link resolution when a doc comment is composed of both inner and outer doc comment) - #163200 (make `RustaceansAreAwesome` satisfy trait bounds) - #163331 (Move `Arc` and `Rc` into `rcs` mod) - #163427 (implement #![feature(gca_adts)]) - #163428 (do not complain about unstable target features on nightly) - #163444 (Add `stable_rustc` helper in `run-make-support`) - #163447 (Allow using different index types when reading and writing to tables) - #163450 (Force the correct type variable to never for method resolution on an adjusted never type)

Avoid recording unnameable `extern crate` aliases in diagnostic metadata the root cause was that block scoped `extern crate` aliases were still being recorded as `ExternCrateSource::Extern(def_id)`. later, diagnostics reused that metadata and attempted to print paths through those aliases, producing unnameable paths such as `crate::_::_my_crate`. this change detects `extern crate` items whose `DefPath` passes through a value namespace (for example inside functions or `const` blocks) and records them as `ExternCrateSource::Path` instead. diagnostics then fall back to the crate name rather than an unnameable alias. Closes #153459

rust-bors · 2026-09-29T04:18:24Z

💔 Test for 74f4062 failed: CI. Failed job:

auto - test-aarch64-apple-1 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-09-29T04:27:15Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-09-29T07:43:43Z

@bors retry

rust-bors · 2026-09-29T07:47:12Z

⌛ Testing commit 2e4b8e5 with merge 2063b57...

Workflow: https://github.com/rust-lang/rust/actions/runs/36538712471

Avoid recording unnameable `extern crate` aliases in diagnostic metadata the root cause was that block scoped `extern crate` aliases were still being recorded as `ExternCrateSource::Extern(def_id)`. later, diagnostics reused that metadata and attempted to print paths through those aliases, producing unnameable paths such as `crate::_::_my_crate`. this change detects `extern crate` items whose `DefPath` passes through a value namespace (for example inside functions or `const` blocks) and records them as `ExternCrateSource::Path` instead. diagnostics then fall back to the crate name rather than an unnameable alias. Closes #153459

JonathanBrouwer · 2026-09-29T08:00:09Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-09-29T08:00:14Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/36538712471

The next pull request likely to be tested is #163472.

…uwer Rollup of 9 pull requests Successful merges: - #158997 (Avoid recording unnameable `extern crate` aliases in diagnostic metadata) - #162655 (next solver: prefer to select impl candidates over global where-clause candidates) - #162832 (add `Div` and `Mul` for `Complex<{float}>`) - #162862 (Fix intra doc link resolution when a doc comment is composed of both inner and outer doc comment) - #163200 (make `RustaceansAreAwesome` satisfy trait bounds) - #163210 (std: split stack overflow module) - #163331 (Move `Arc` and `Rc` into `rcs` mod) - #163183 (Add .seek_read_buf_exact() to std::os::windows::fs::FileExt) - #163450 (Force the correct type variable to never for method resolution on an adjusted never type)

Rollup merge of #158997 - raushan728:issues/153459, r=petrochenkov Avoid recording unnameable `extern crate` aliases in diagnostic metadata the root cause was that block scoped `extern crate` aliases were still being recorded as `ExternCrateSource::Extern(def_id)`. later, diagnostics reused that metadata and attempted to print paths through those aliases, producing unnameable paths such as `crate::_::_my_crate`. this change detects `extern crate` items whose `DefPath` passes through a value namespace (for example inside functions or `const` blocks) and records them as `ExternCrateSource::Path` instead. diagnostics then fall back to the crate name rather than an unnameable alias. Closes #153459

…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#158997 (Avoid recording unnameable `extern crate` aliases in diagnostic metadata) - rust-lang/rust#162655 (next solver: prefer to select impl candidates over global where-clause candidates) - rust-lang/rust#162832 (add `Div` and `Mul` for `Complex<{float}>`) - rust-lang/rust#162862 (Fix intra doc link resolution when a doc comment is composed of both inner and outer doc comment) - rust-lang/rust#163200 (make `RustaceansAreAwesome` satisfy trait bounds) - rust-lang/rust#163210 (std: split stack overflow module) - rust-lang/rust#163331 (Move `Arc` and `Rc` into `rcs` mod) - rust-lang/rust#163183 (Add .seek_read_buf_exact() to std::os::windows::fs::FileExt) - rust-lang/rust#163450 (Force the correct type variable to never for method resolution on an adjusted never type)

rustbot assigned TaKO8Ki Jul 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2026

cjgillot reviewed Aug 4, 2026

View reviewed changes

Comment thread compiler/rustc_middle/src/ty/print/pretty.rs Outdated

cjgillot self-assigned this Aug 4, 2026

raushan728 force-pushed the issues/153459 branch from 264014a to 6940778 Compare August 6, 2026 07:28

This comment has been minimized.

Sign in to view

raushan728 force-pushed the issues/153459 branch 2 times, most recently from b236ee3 to 5d31258 Compare August 6, 2026 07:39

This comment has been minimized.

Sign in to view

raushan728 requested a review from cjgillot August 6, 2026 07:58

This comment has been minimized.

Sign in to view

raushan728 force-pushed the issues/153459 branch from 5d31258 to f9f0a04 Compare August 6, 2026 13:04

raushan728 changed the title ~~Avoid suggesting crate::_::_... paths for trait imports~~ Avoid recording unnameable extern crate aliases in diagnostic metadata Aug 6, 2026

raushan728 added 2 commits September 27, 2026 09:05

test(imports): add baseline regression for hidden extern crate sugges…

188011a

…tion

raushan728 force-pushed the issues/153459 branch from f9f0a04 to 2e4b8e5 Compare September 27, 2026 10:35

rustbot assigned tiif and unassigned cjgillot and TaKO8Ki Sep 27, 2026

rustbot assigned nnethercote and unassigned tiif Sep 27, 2026

rustbot assigned petrochenkov and unassigned nnethercote Sep 27, 2026

raushan728 mentioned this pull request Sep 28, 2026

Fix incorrect typo suggestion for struct field shorthands #163370

Merged

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2026

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 12 pull requests #163456

Closed

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 15 pull requests #163460

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026

JonathanBrouwer mentioned this pull request Sep 29, 2026

Rollup of 9 pull requests #163472

Merged

rust-bors Bot merged commit dce0308 into rust-lang:main Sep 29, 2026
13 of 14 checks passed

rustbot added this to the 1.101.0 milestone Sep 29, 2026

raushan728 deleted the issues/153459 branch September 29, 2026 11:32

github-actions Bot mentioned this pull request Oct 3, 2026

Toolchain upgrade to nightly-2026-10-02 flux-rs/flux#1811

Draft

Uh oh!

Conversation

raushan728 commented Jul 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 27, 2026

Uh oh!

raushan728 commented Sep 27, 2026

Uh oh!

nnethercote commented Sep 27, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 29, 2026

Uh oh!

rust-log-analyzer commented Sep 29, 2026

Uh oh!

JonathanBrouwer commented Sep 29, 2026

Uh oh!

rust-bors Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Sep 29, 2026

Uh oh!

rust-bors Bot commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

raushan728 commented Jul 9, 2026 •

edited by rustbot

Loading

rust-bors Bot commented Sep 29, 2026 •

edited

Loading