Remove fields from TypeKind: Array, Slice by yara-blue · Pull Request #161896 · rust-lang/rust

yara-blue · 2026-08-27T23:28:12Z

Tracking issue #146922

Part of the Refactoring to many methods reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum TypeKind where the variants hold the types information to one that just tells you the type kind. Separate methods on TypeId provide a way to get to the data that used to be in the variant.

r? @oli-obk

rustbot · 2026-08-27T23:28:16Z

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The reflection data structures are tied exactly to the implementation
in the compiler. Make sure to also adjust rustc_const_eval/src/const_eval/type_info.rs

cc @oli-obk

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-08-27T23:28:18Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-09-07T10:27:46Z

📌 Commit 75746ce has been approved by oli-obk

It is now in the queue for this repository.

@oli-obk

…y-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk

@oli-obk

…y-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk

@oli-obk

…y-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk

…uwer Rollup of 3 pull requests Successful merges: - #161896 (Remove fields from TypeKind: Array, Slice) - #162354 (Make comptime functions ineligible for coverage) - #162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function) Failed merges: - #162294 (Reflection refactor ptrs)

JonathanBrouwer · 2026-09-07T12:20:37Z

@bors try jobs=test-armhf-gnu

…<try> Remove fields from TypeKind: Array, Slice try-job: test-armhf-gnu

JonathanBrouwer · 2026-09-07T12:22:17Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162417 (comment)

Most likely this PR but not 100% sure, therefore starting try job

rust-bors · 2026-09-07T12:22:26Z

This pull request was unapproved.

This PR was contained in a rollup (#162417), which was unapproved.

View changes since this unapproval

yara-blue · 2026-09-07T13:06:19Z

Most likely this PR but not 100% sure, therefore starting try job

I'm 95% sure it is :3

Fix is on the way, should I try build after?

JonathanBrouwer · 2026-09-07T13:08:08Z

Yes please
@bors delegate=try

rust-bors · 2026-09-07T13:08:11Z

✌️ @yara-blue, you can now perform try builds on this pull request!

Warning

You used the legacy format of the delegate command.
The new format is @bors delegate[=<username>] [<try|review>].

You can now post @bors try to start a try build.

rust-bors · 2026-09-07T13:26:41Z

💔 Test for bd65654 failed: CI. Failed job:

try - test-armhf-gnu (web logs, enhanced plaintext logs)

yara-blue · 2026-09-07T14:33:50Z

@bors try jobs=test-armhf-gnu

…<try> Remove fields from TypeKind: Array, Slice try-job: test-armhf-gnu

rust-bors · 2026-09-07T16:04:58Z

☀️ Try build successful (CI)
Build commit: 6136c36 (6136c36c624ceef2235f781619dfbd8b50397c6a)
Base parent: 656a9da (656a9da186dacaf3bf8f7f7296a825d256cb4ae3)

yara-blue · 2026-09-07T17:11:25Z

@JonathanBrouwer This one passes now, the code unintentionally assumed an int to always be 64 bit, that's fixed now 🥳

Should be good for another rollup

JonathanBrouwer · 2026-09-07T17:28:46Z

@bors r=oli-obk

rust-bors · 2026-09-07T17:28:48Z

📌 Commit 86729db has been approved by oli-obk

It is now in the queue for this repository.

rustbot · 2026-09-07T19:23:30Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-09-07T19:27:48Z

@bors r=oli-obk

rust-bors · 2026-09-07T19:27:51Z

📌 Commit ed8f8b6 has been approved by oli-obk

It is now in the queue for this repository.

…uwer Rollup of 5 pull requests Successful merges: - #162436 (Replace links to `github.com/rust-lang/rfcs` with links to the Rust RFC Book) - #162438 (codegen_llvm: use minimum/maximum intrinsics now that they got fixed) - #161896 (Remove fields from TypeKind: Array, Slice) - #162276 (Avoid wrong suggestions for never type coerce) - #162421 (Raise a delayed bug when comparing incompatible constructors)

@oli-obk

Rollup merge of #161896 - yara-blue:reflection-refactor-array-slice, r=oli-obk Remove fields from TypeKind: Array, Slice Tracking issue #146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. r? @oli-obk

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2026

rustbot assigned oli-obk Aug 27, 2026

oli-obk approved these changes Sep 7, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026

JonathanBrouwer mentioned this pull request Sep 7, 2026

Rollup of 3 pull requests #162415

Closed

JonathanBrouwer mentioned this pull request Sep 7, 2026

Rollup of 4 pull requests #162416

Closed

JonathanBrouwer mentioned this pull request Sep 7, 2026

Rollup of 3 pull requests #162417

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026

Auto merge of #161896 - yara-blue:reflection-refactor-array-slice, r=…

bd65654

…<try> Remove fields from TypeKind: Array, Slice try-job: test-armhf-gnu

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2026

This comment has been minimized.

Sign in to view

yara-blue force-pushed the reflection-refactor-array-slice branch from 75746ce to 86729db Compare September 7, 2026 13:27

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026

Auto merge of #161896 - yara-blue:reflection-refactor-array-slice, r=…

6136c36

…<try> Remove fields from TypeKind: Array, Slice try-job: test-armhf-gnu

This comment has been minimized.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2026

yara-blue added 2 commits September 7, 2026 20:58

reflection: replace TypeKind::Slice's field with TypeId::element_ty

2edd314

reflection: replace TypeKind::Array field with methods

ed8f8b6

yara-blue force-pushed the reflection-refactor-array-slice branch from 86729db to ed8f8b6 Compare September 7, 2026 19:23

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2026

JonathanBrouwer mentioned this pull request Sep 7, 2026

Rollup of 5 pull requests #162445

Merged

rust-bors Bot merged commit 501a26c into rust-lang:main Sep 8, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 8, 2026

Uh oh!

Uh oh!

Conversation

yara-blue commented Aug 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 27, 2026

Uh oh!

rustbot commented Aug 27, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

yara-blue commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

This comment has been minimized.

yara-blue commented Sep 7, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 7, 2026

Uh oh!

yara-blue commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 7, 2026

Uh oh!

JonathanBrouwer commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yara-blue commented Aug 27, 2026 •

edited by rustbot

Loading

oli-obk left a comment •

edited by rustbot

Loading

JonathanBrouwer commented Sep 7, 2026 •

edited

Loading