Skip to content

abi/compatibility test: add simple float type - #161991

Draft
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:float-abi-compat
Draft

abi/compatibility test: add simple float type#161991
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:float-abi-compat

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2026
@RalfJung RalfJung mentioned this pull request Aug 29, 2026
Open
@folkertdev

folkertdev commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

For that is_single_fp_element bug you'd need either i686-pc-windows-gnu or pass -Zreg-struct-return, see #161987.

@beetrees

beetrees commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

For is_single_fp_element, the f32 needs to be wrapped in a #[repr(C)] struct: #[repr(C)] struct Foo(f32); test_transparent!(float_struct, Foo);.

@RalfJung

RalfJung commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

Ah yes, that does indeed produce failures.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Aug 30, 2026
@RalfJung RalfJung mentioned this pull request Aug 30, 2026
Open
@RalfJung

RalfJung commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@folkertdev #161987 indeed fixes the new tests for everything except for MIPS (and MIPS ABI is known to be broken for years, it's an unmaintained broken target that IMO should be removed).

Maybe you could cherry-pick the new test from this PR into yours?

@folkertdev

folkertdev commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

sure, I've cherry-picked it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @folkertdev @beetrees @rust-log-analyzer @rustbot