Skip to content

unseal std::io::IsTerminal - #162012

Open
GrigorenkoPV wants to merge 1 commit into
rust-lang:mainfrom
GrigorenkoPV:unseal_terminal
Open

unseal std::io::IsTerminal#162012
GrigorenkoPV wants to merge 1 commit into
rust-lang:mainfrom
GrigorenkoPV:unseal_terminal

Conversation

@GrigorenkoPV

@GrigorenkoPV GrigorenkoPV commented Aug 30, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 30, 2026
@rustbot

rustbot commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

r? @nia-e

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@Mark-Simulacrum Mark-Simulacrum added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-t-libs Status: Awaiting decision from T-libs and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2026
@clarfonthey

clarfonthey commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@rfcbot fcp merge libs

@rust-rfcbot

rust-rfcbot commented Aug 30, 2026 •
edited by dtolnay
Loading

Copy link
Copy Markdown
Collaborator

@clarfonthey has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. and removed needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nia-e nia-e

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-t-libs Status: Awaiting decision from T-libs T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: io::IsTerminal should not be sealed

6 participants

@GrigorenkoPV @rustbot @clarfonthey @rust-rfcbot @Mark-Simulacrum @nia-e