Make the LLVM version mismatch ICE a fatal error - #162034
Merged
rust-bors[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
Collaborator
|
|
rustbot
added
A-LLVM
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @ShoyuVanilla. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nnethercote
approved these changes
Aug 31, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup of 8 pull requests Successful merges: - #161301 (libcore: expose volatile atomic operations) - #161379 (Use better generic type parameter names for `Extend` and `FromIterator`) - #161926 (borrowck: Restore alias rigidity from HIR typeck) - #161956 (Remove unused `perform_locally_with_next_solver`) - #162026 (Emit delayed bug instead of ICEing when `TypeOutlives` goal fails) - #162034 (Make the LLVM version mismatch ICE a fatal error) - #162037 (LLVM wrapper cleanups) - #162043 (_ an unused parameter)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rollup merge of #162034 - saethlin:llvm-version-mismatch-error, r=nnethercote Make the LLVM version mismatch ICE a fatal error It was pointed out to me that the diatnostic in #161788 has the usual ICE messages about how this is a bug and we'd appreciate a report. But it isn't, and a fatal error is a better way to report the problem. Manually tested on MacOS: ``` $ export DYLD_LIBRARY_PATH=/opt/homebrew/opt/llvm@21/lib $ rustc +stage1 --print=sysroot error: LLVM version mismatch: this compiler was built for LLVM 23, but LLVM 21.1.8 was found at /opt/homebrew/Cellar/llvm@21/21.1.8/lib/libLLVM.dylib $ unset DYLD_LIBRARY_PATH $ rustc +stage1 --print=sysroot /Users/ben.kimock/rust/build/aarch64-apple-darwin/stage1 ```
Collaborator
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (fdeb69b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -1.0%, secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: missing data |
jieyouxu
added
the
beta-nominated
Collaborator
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
[beta] backports - Avoid arming the Windows TLS destructor guard in fibers #161451 - (partial) stdarch subtree update #161558 - Check to ensure we're running against the correct LLVM version #161788 - Make the LLVM version mismatch ICE a fatal error #162034 - Revert "Add `rustc_test_entrypoint_marker`" #161931 - Fix ICE of getting name from RPITIT #162071 - Update LLVM submodule #162133 - Revert "Implement Debug for C-like enums with a concatenated string" #162164 r? me
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
[beta] backports - Avoid arming the Windows TLS destructor guard in fibers #161451 - (partial) stdarch subtree update #161558 - Check to ensure we're running against the correct LLVM version #161788 - Make the LLVM version mismatch ICE a fatal error #162034 - Revert "Add `rustc_test_entrypoint_marker`" #161931 - Fix ICE of getting name from RPITIT #162071 - Update LLVM submodule #162133 - Revert "Implement Debug for C-like enums with a concatenated string" #162164 r? me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out to me that the diatnostic in #161788 has the usual ICE messages about how this is a bug and we'd appreciate a report. But it isn't, and a fatal error is a better way to report the problem. Manually tested on MacOS: