Update LLVM submodule - #162133
Conversation
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
|
Beta nomination includes the previous update in #161466 as well. The LLVM 23 version on beta is very old at this point (I think from around rc1), and a lot of issues have since been fixed. We should avoid shipping pre-release LLVM on beta. |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (fbd8c6c): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (primary 0.8%, secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 473.301s -> 475.129s (0.39%) |
|
@bors r+ |
|
@bors rollup=never
|
|
@bors p=1 submodule |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c25253f (parent) -> 3a43cb6 (this PR) Test differencesShow 65 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3a43cb66f97d08ccde87a00599fac2d3c50eb177 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (3a43cb6): comparison URL. Overall result: no relevant changes - BENCHMARK(S) FAILED@rustbot label: -perf-regression ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ cc @rust-lang/wg-compiler-performance Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: missing data |
|
The failure is not caused by this PR. |
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
[beta] backports - Avoid arming the Windows TLS destructor guard in fibers #161451 - (partial) stdarch subtree update #161558 - Check to ensure we're running against the correct LLVM version #161788 - Make the LLVM version mismatch ICE a fatal error #162034 - Revert "Add `rustc_test_entrypoint_marker`" #161931 - Fix ICE of getting name from RPITIT #162071 - Update LLVM submodule #162133 - Revert "Implement Debug for C-like enums with a concatenated string" #162164 r? me
[beta] backports - Avoid arming the Windows TLS destructor guard in fibers #161451 - (partial) stdarch subtree update #161558 - Check to ensure we're running against the correct LLVM version #161788 - Make the LLVM version mismatch ICE a fatal error #162034 - Revert "Add `rustc_test_entrypoint_marker`" #161931 - Fix ICE of getting name from RPITIT #162071 - Update LLVM submodule #162133 - Revert "Implement Debug for C-like enums with a concatenated string" #162164 r? me
Update to current release/23.x, which is a bit past the LLVM 23.1.0 release.
Fixes #161336.