Skip to content

Clean up some small things related to lint ambiguous_glob_imported_traits - #162176

Open
fmease wants to merge 2 commits into
rust-lang:mainfrom
fmease:clean-up-ambig-glob-imp-traits
Open

Clean up some small things related to lint ambiguous_glob_imported_traits#162176
fmease wants to merge 2 commits into
rust-lang:mainfrom
fmease:clean-up-ambig-glob-imp-traits

Conversation

@fmease

@fmease fmease commented Sep 2, 2026

Copy link
Copy Markdown
Member

Cleaning up things I noticed in the vicinity while reviewing PR #157968 (which concerns lint ambiguous_glob_imported_traits and feature supertrait_item_shadowing).

Namely,

  1. turning two tuple struct variants into named ones to avoid "anonymous bools"
  2. fixing an inaccurate supertrait_item_shadowing-specific doc comment
  3. applying the rules listed in our Diagnostic output style guide to the diagnostic of lint ambiguous_glob_imported_traits

(No LLM was or will be used by me during the entire creation process of this PR)

@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Sep 2, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2026
@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 21 candidates

@fmease fmease changed the title Clean up ambig glob imp traits Clean up some small things related to lint ambiguous_glob_imported_traits Sep 2, 2026
@rust-log-analyzer

This comment has been minimized.

@fmease
fmease force-pushed the clean-up-ambig-glob-imp-traits branch 2 times, most recently from a65b61a to 6c0654e Compare September 2, 2026 09:58
…tylistic conventions

Namely:

> Error, Warning, Note, and Help messages start with a lowercase letter and do not end with punctuation.

From: <https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants