Skip to content

Crater rollup - #162233

Draft
theemathas wants to merge 16 commits into
rust-lang:mainfrom
theemathas:crater-rollup
Draft

Crater rollup#162233
theemathas wants to merge 16 commits into
rust-lang:mainfrom
theemathas:crater-rollup

Conversation

@theemathas

@theemathas theemathas commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

r? ghost

Due to the long crater queue, I am making a crater rollup. That is, I will run crater of all these PRs together at the same time. And then, once that is finished, I will rerun crater on each individual PR only on the crates that regressed in the result of this crater. This hopefully will speed up the crater process.

PRs in this rollup: #160780, #160902, #161358, #161253, #161946, #160391, #161319

beepster4096 and others added 15 commits September 3, 2026 19:11
@beepster4096 @theemathas
fix borrowck not considering sibling index and constantindex projecti…
f11bed9 
…ons to be overlapping in some cases
@beepster4096 @theemathas
use ProjectionKind instead of PlaceElem for LookupResult and match ex…
104f67c 
…haustively on it
@dianne @theemathas
respect borrow kind in kill_borrows_on_place
e10aa5e
@fmease @theemathas
Also enforce dyn compatibility in (unchecked) type aliases
b97d341
@kpreid @theemathas
Implement AsMut<T> and AsRef<T> for !.
7aa38c1 
This will allow e.g. `&[!]` to satisfy `&[T] where T: AsRef<str>`.
It follows the recommendation from the never documentation:

> When writing your own traits, `!` should have an `impl` whenever
> there is an obvious `impl` which doesn’t `panic!`.

-- <https://doc.rust-lang.org/1.97.1/std/primitive.never.html#-and-traits>

The test tests/ui/impl-trait/generic-with-implicit-hrtb-without-dyn.rs
had to be updated because it depended on this impl not existing. I’ve
confirmed that the modified test still functions as a regression test by
compiling it in nightly-2022-08-28 and seeing it ICE.
@nia-e @theemathas
generalise impls on box
e6d5195
@ShaddyDC @theemathas
Add #[rustc_anti_fundamental] attribute
30d8dc7 
This adds a new compiler attribute that prevents non-local fundamental
types from receiving implementations of marked traits.
This allows addressing soundness problems with traits like DerefMut on
Pin and similar wrapper types.
The attribute is checked during the orphan check in coherence.
@ShaddyDC @theemathas
Annotate std traits with #[rustc_anti_fundamental]
269e4c6 
Mark Deref, DerefMut, DispatchFromDyn, CoerceUnsized, and Receiver
with #[rustc_anti_fundamental] to prevent downstream crates from
implementing these traits on #[fundamental] types like Box and Pin.
@ShaddyDC @theemathas
Remove PinDerefMutHelper
8df2981 
We marked DerefMut anti-fundamental, so the PinHelper indirection is no
longer needed to prevent downstream users from implementing DerefMut on
Pin.
@lumi-me-not @theemathas
rustc_hir_analysis: register all clauses of DefKind::Fn as obligations
ca9f874
@lumi-me-not @theemathas
rustc_hir_analysis: move function clause checks into its own function
11258a6
@lumi-me-not @theemathas
tests: add test for rust-lang#151319
17a596d
@lumi-me-not @theemathas
tests: rename issue-151319 to check-fn-clauses-issue-151319
d02ad6b
@lumi-me-not @theemathas
rustc_hir_analysis: change ObligationCauseCode for check_function_cla…
9a29c79 
…uses
@lumi-me-not @theemathas
tests: fix a few of the ui tests that were broken by check_function_c…
2fd2aba 
…lauses
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) O-solid Operating System: SOLID O-windows Operating system: Windows S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 3, 2026
@theemathas

theemathas commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
@bors
Auto merge of #162233 - theemathas:crater-rollup, r=<try>
d30f5d2 
Crater rollup
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for d30f5d2 failed: CI. Failed jobs:

@theemathas

theemathas commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
@bors
Auto merge of #162233 - theemathas:crater-rollup, r=<try>
79c0559 
Crater rollup
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 79c0559 (79c0559184f27f4433a6fbc260b950d06d4a4889)
Base parent: 4fcf397 (4fcf39725a9c99bd495d8c73af83628a256ff9a9)

@theemathas

theemathas commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@craterbot check name=pr-162233-crater-rollup p=3

@craterbot

craterbot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-162233-crater-rollup created and queued.
🤖 Automatically detected try build 79c0559
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2026
This was referenced Sep 3, 2026
Open
Open
Draft
Open
Open
Draft
Draft
@clarfonthey

clarfonthey commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Genuine question: if crater runs are getting backed more frequently, should crater rollups just become part of the routine process? e.g., should we maybe start explicitly planning for them rather than just ad-hoc queueing things?

@craterbot

craterbot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-162233-crater-rollup is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-162233-crater-rollup is completed!
📊 2109 regressed and 0 fixed (1103609 total)
📊 5779 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-162233-crater-rollup/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) O-solid Operating System: SOLID O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.