Skip to content

Make Receiver #[rustc_dyn_incompatible_trait] - #162411

Open
Darksonn wants to merge 2 commits into
rust-lang:mainfrom
Darksonn:receiver-dyn-incompat
Open

Make Receiver #[rustc_dyn_incompatible_trait]#162411
Darksonn wants to merge 2 commits into
rust-lang:mainfrom
Darksonn:receiver-dyn-incompat

Conversation

@Darksonn

@Darksonn Darksonn commented Sep 7, 2026

Copy link
Copy Markdown
Member

Fixes: #149094

r? dingxiangfei2009

@Darksonn Darksonn added F-arbitrary_self_types `#![feature(arbitrary_self_types)]` A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) labels Sep 7, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 7, 2026
@dingxiangfei2009

Copy link
Copy Markdown
Contributor

Indeed, the effort to make dyn Receiver: Receiver work in the compiler is insurmountable.

@bors r+

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c317698 has been approved by dingxiangfei2009

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
@rust-log-analyzer

This comment has been minimized.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 7, 2026
…dingxiangfei2009

Make Receiver `#[rustc_dyn_incompatible_trait]`

Fixes: rust-lang#149094

r? dingxiangfei2009
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 7, 2026
…dingxiangfei2009

Make Receiver `#[rustc_dyn_incompatible_trait]`

Fixes: rust-lang#149094

r? dingxiangfei2009
@JonathanBrouwer

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162415 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2026
@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162416), which was unapproved.

View changes since this unapproval

@Darksonn

Darksonn commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) F-arbitrary_self_types `#![feature(arbitrary_self_types)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receiver and DispatchFromDyn probably shouldn't be dyn-compatible?

5 participants