Conversation
rustbot
added
S-waiting-on-author
dianne
commented
Sep 23, 2026
| } | ||
| } | ||
|
|
||
| // FIXME: this is gonna need to be removed ... |
Member
Author
There was a problem hiding this comment.
maybe this FIXME should be duplicated? for now I've just kept it on the function it was originally on
dianne
commented
Sep 23, 2026
dianne
marked this pull request as ready for review
September 23, 2026 13:04
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
dianne
force-pushed
the
normalize-param-env-or-delay-bugs
branch
from
September 25, 2026 15:59
4c5bda2 to
c2977b5
Compare
This comment has been minimized.
This comment has been minimized.
dianne
force-pushed
the
normalize-param-env-or-delay-bugs
branch
from
September 29, 2026 11:22
c2977b5 to
2307f01
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #138174, when checking if a trait's methods' receivers are dyn-dispatchable, we call
normalize_param_env_or_error, which is prone to reporting duplicate errors and confusing errors involving the placeholder typeRustaceansAreAwesome. This makes those all delayed bugs instead. As a consequence, code that only hasRustaceansAreAwesomeerrors (e.g. #161621) will now ICE, which I think is more appropriate.This gets rid of the extra
RustaceansAreAwesomeerrors introduced by #163200.