rustc_builtin_macros cleanup, part 7 - #163389
Merged
Merged
Conversation
There are already way too many helpers to construct paths in this crate and this one is not very useful.
In all cases, the passed span was already the span of the ident.
Collaborator
|
Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs cc @ZuseZ4 |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
Bot
force-pushed
the
builtin-macros-7
branch
from
September 27, 2026 12:45
f887328 to
a416ef1
Compare
Most of these cases were found by searching for uses of `DUMMY_NODE_ID`.
Also inline `lambda0` and `lambda1` since they're only used once and are trivial wrappers around `lambda`.
It is much more similar to the methods there than to the methods in `base.rs`.
`new_inputs` and `idents` are never read anywhere, several other `Vec`s are supposed to be `ThinVec`s instead.
rust-cloud-vms
Bot
force-pushed
the
builtin-macros-7
branch
from
September 27, 2026 13:24
a416ef1 to
529a0ae
Compare
nnethercote
approved these changes
Sep 27, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup of 11 pull requests Successful merges: - #163085 (Suggest similarly named modules in import paths) - #163098 ([debugger visualizers] Add workaround to read `Rc` strong/weak counts) - #163120 (ci: make musl.sh look for patches next to the script) - #163301 (Fix unused_must_use for scenario which may need to keep value) - #163307 (Less `SpanData` in diagnostics) - #163389 (`rustc_builtin_macros` cleanup, part 7) - #152972 (implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]) - #162536 (Implement Default for NumBuffer) - #163141 (Document safety requirements for intrinsic fallbacks) - #163384 (Various clean-ups around `LayoutCalculator`) - #163413 (mailmap: add Matilde Morrone)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup merge of #163389 - cyrgani:builtin-macros-7, r=nnethercote `rustc_builtin_macros` cleanup, part 7 This PR mainly focuses on the various helpers on `ExtCtxt`. Several of these are unused and were removed, others were added or used in more places. It also removes a few of the currently too many ways to construct a `Path`, in preparation of a single unified way in a future PR. Previous PR in the series: #163211 r? @nnethercote
github-actions Bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Oct 1, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#163085 (Suggest similarly named modules in import paths) - rust-lang/rust#163098 ([debugger visualizers] Add workaround to read `Rc` strong/weak counts) - rust-lang/rust#163120 (ci: make musl.sh look for patches next to the script) - rust-lang/rust#163301 (Fix unused_must_use for scenario which may need to keep value) - rust-lang/rust#163307 (Less `SpanData` in diagnostics) - rust-lang/rust#163389 (`rustc_builtin_macros` cleanup, part 7) - rust-lang/rust#152972 (implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]) - rust-lang/rust#162536 (Implement Default for NumBuffer) - rust-lang/rust#163141 (Document safety requirements for intrinsic fallbacks) - rust-lang/rust#163384 (Various clean-ups around `LayoutCalculator`) - rust-lang/rust#163413 (mailmap: add Matilde Morrone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly focuses on the various helpers on
ExtCtxt. Several of these are unused and were removed, others were added or used in more places. It also removes a few of the currently too many ways to construct aPath, in preparation of a single unified way in a future PR.Previous PR in the series: #163211
r? @nnethercote