Skip to content

Add stable_bare_rustc helper in run-make-support - #163444

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:run-make-stable-benchmarks
Sep 29, 2026
Merged

Add stable_bare_rustc helper in run-make-support#163444
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:run-make-stable-benchmarks

Conversation

@Kobzol

@Kobzol Kobzol commented Sep 28, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

To help with #162848 and https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Testing.20stable.20vs.20nightly.20behavior.20in.20UI.20tests/with/626329887.

For #162848, I need to avoid passing -Zthreads when the compiler is supposed to act like stable. This refactoring makes that simpler; I will only add that flag to Rustc::new and not Rustc::stable.

r? jieyouxu

@rustbot

rustbot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

The run-make-support library was changed

cc @jieyouxu

@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Sep 28, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2026
@Kobzol
Kobzol force-pushed the run-make-stable-benchmarks branch from d2b7912 to 3408cf9 Compare September 28, 2026 13:41
jieyouxu
jieyouxu approved these changes Sep 28, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit. r=me after

View changes since this review

Comment thread src/tools/run-make-support/src/external_deps/rustc.rs Outdated
@Kobzol
Kobzol force-pushed the run-make-stable-benchmarks branch from 3408cf9 to 773ad19 Compare September 28, 2026 14:03
@jieyouxu

jieyouxu commented Sep 28, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 773ad19 has been tentatively approved by jieyouxu

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 28, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163444 - Kobzol:run-make-stable-benchmarks,…
69dd605 
… r=jieyouxu

Add `stable_rustc` helper in `run-make-support`

To help with rust-lang#162848 and https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Testing.20stable.20vs.20nightly.20behavior.20in.20UI.20tests/with/626329887.

For rust-lang#162848, I need to avoid passing `-Zthreads` when the compiler is supposed to act like `stable`. This refactoring makes that simpler; I will only add that flag to `Rustc::new` and not `Rustc::stable`.

r? jieyouxu
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 28, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 28, 2026
@bors
Auto merge of #163460 - JonathanBrouwer:rollup-OIZLNAi, r=JonathanBro…
eba8d41 
…uwer

Rollup of 15 pull requests

Successful merges:

 - #158936 (Add `std::fs::{Home|Media}Dirs`)
 - #129036 (Additional NonZero conversions)
 - #158997 (Avoid recording unnameable `extern crate` aliases in diagnostic metadata)
 - #161015 (Stabilize `funnel_shifts` (including `const`))
 - #161712 (Stabilize `Result::into_{ok,err}`)
 - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime)
 - #162655 (next solver: prefer to select impl candidates over global where-clause candidates)
 - #162862 (Fix intra doc link resolution when a doc comment is composed of both inner and outer doc comment)
 - #163200 (make `RustaceansAreAwesome` satisfy trait bounds)
 - #163331 (Move `Arc` and `Rc` into `rcs` mod)
 - #163427 (implement #![feature(gca_adts)])
 - #163428 (do not complain about unstable target features on nightly)
 - #163444 (Add `stable_rustc` helper in `run-make-support`)
 - #163447 (Allow using different index types when reading and writing to tables)
 - #163450 (Force the correct type variable to never for method resolution on an adjusted never type)
@tgross35 tgross35 mentioned this pull request Sep 29, 2026
Merged
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 29, 2026
@tgross35
Rollup merge of rust-lang#163444 - Kobzol:run-make-stable-benchmarks,…
edeb5bd 
… r=jieyouxu

Add `stable_rustc` helper in `run-make-support`

To help with rust-lang#162848 and https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Testing.20stable.20vs.20nightly.20behavior.20in.20UI.20tests/with/626329887.

For rust-lang#162848, I need to avoid passing `-Zthreads` when the compiler is supposed to act like `stable`. This refactoring makes that simpler; I will only add that flag to `Rustc::new` and not `Rustc::stable`.

r? jieyouxu
@tgross35 tgross35 mentioned this pull request Sep 29, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026
@bors
Auto merge of #163465 - tgross35:rollup-VJQsybH, r=tgross35
80a4f6c 
Rollup of 9 pull requests

Successful merges:

 - #161015 (Stabilize `funnel_shifts` (including `const`))
 - #161712 (Stabilize `Result::into_{ok,err}`)
 - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime)
 - #163427 (implement #![feature(gca_adts)])
 - #163390 (add `automatically_derived` attribute documentation)
 - #163428 (do not complain about unstable target features on nightly)
 - #163444 (Add `stable_rustc` helper in `run-make-support`)
 - #163447 (Allow using different index types when reading and writing to tables)
 - #163459 (Stabilize vec_try_remove)
@rust-bors
rust-bors Bot merged commit 41d560b into rust-lang:main Sep 29, 2026
13 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Sep 29, 2026
@Kobzol
Kobzol deleted the run-make-stable-benchmarks branch September 29, 2026 07:19
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Sep 30, 2026
@bors
Auto merge of #163465 - tgross35:rollup-VJQsybH, r=tgross35
ae1e67f 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#161015 (Stabilize `funnel_shifts` (including `const`))
 - rust-lang/rust#161712 (Stabilize `Result::into_{ok,err}`)
 - rust-lang/rust#162493 (Add support for -Zsanitizer-cfi-minimal-runtime)
 - rust-lang/rust#163427 (implement #![feature(gca_adts)])
 - rust-lang/rust#163390 (add `automatically_derived` attribute documentation)
 - rust-lang/rust#163428 (do not complain about unstable target features on nightly)
 - rust-lang/rust#163444 (Add `stable_rustc` helper in `run-make-support`)
 - rust-lang/rust#163447 (Allow using different index types when reading and writing to tables)
 - rust-lang/rust#163459 (Stabilize vec_try_remove)
pull Bot pushed a commit to xtqqczze/rust-lang-rustc-dev-guide that referenced this pull request Sep 30, 2026
@bors
Auto merge of #163465 - tgross35:rollup-VJQsybH, r=tgross35
46a85c1 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#161015 (Stabilize `funnel_shifts` (including `const`))
 - rust-lang/rust#161712 (Stabilize `Result::into_{ok,err}`)
 - rust-lang/rust#162493 (Add support for -Zsanitizer-cfi-minimal-runtime)
 - rust-lang/rust#163427 (implement #![feature(gca_adts)])
 - rust-lang/rust#163390 (add `automatically_derived` attribute documentation)
 - rust-lang/rust#163428 (do not complain about unstable target features on nightly)
 - rust-lang/rust#163444 (Add `stable_rustc` helper in `run-make-support`)
 - rust-lang/rust#163447 (Allow using different index types when reading and writing to tables)
 - rust-lang/rust#163459 (Stabilize vec_try_remove)
clarfonthey pushed a commit to clarfonthey/stdarch that referenced this pull request Sep 30, 2026
@bors
Auto merge of #163465 - tgross35:rollup-VJQsybH, r=tgross35
45a969c 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#161015 (Stabilize `funnel_shifts` (including `const`))
 - rust-lang/rust#161712 (Stabilize `Result::into_{ok,err}`)
 - rust-lang/rust#162493 (Add support for -Zsanitizer-cfi-minimal-runtime)
 - rust-lang/rust#163427 (implement #![feature(gca_adts)])
 - rust-lang/rust#163390 (add `automatically_derived` attribute documentation)
 - rust-lang/rust#163428 (do not complain about unstable target features on nightly)
 - rust-lang/rust#163444 (Add `stable_rustc` helper in `run-make-support`)
 - rust-lang/rust#163447 (Allow using different index types when reading and writing to tables)
 - rust-lang/rust#163459 (Stabilize vec_try_remove)
@Kobzol Kobzol changed the title Add stable_rustc helper in run-make-support Add stable_bare_rustc helper in run-make-support Oct 2, 2026
@Kobzol Kobzol mentioned this pull request Oct 2, 2026
Open
@github-actions github-actions Bot mentioned this pull request Oct 3, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Kobzol @rustbot @jieyouxu