Repository navigation
Rollup of 7 pull requests - #163446
Closed
JonathanBrouwer wants to merge 17 commits into
Closed
Rollup of 7 pull requests#163446JonathanBrouwer wants to merge 17 commits into
JonathanBrouwer wants to merge 17 commits into
Conversation
Rustc already defaults to this for regular items whenever possible. Overriding it would only lead to linker errors. And for depending on the exact codegen unit partitioning rustc uses, so there it is a bad idea to use it too.
Rustc already defaults to this for #[no_mangle]/#[export_name] items. There is no reason to explicitly use it.
This function is a wrapper around `Symbol::intern`, which is already checked by the `rustc::symbol_intern_string_literal` lint.
A common definition is like a weak definition except that it must be a zero-initialized static and when merging two common symbols with the same name, the size and alignment are set to the higher of both symbols. This is used for tentative definitions in C and doesn't have any reason to exist outside of that. This behavior doesn't work across dylibs and common symbols have inconsistent behavior across linkers [1]. It is also fragile to rely on getting the largest size of all common symbol definitions as a (possibly smaller) global definition can override it. Link: https://maskray.me/blog/all-about-common-symbols [1]
remove `MutTy` This PR removes `ast::MutTy` and `hir::MutTy` and inlines their two fields directly into their corresponding `TypeKind` variants. These types probably made sense in pre-1.0 versions where it still had a syntax-level representation with things like `[mut T]`. Nowadays, it is just a type that is used in some, but not all places to group a type and a mutability together (for example, `rustc_type_ir` does not include such a wrapper). It also has no methods and just makes some match statements more verbose. Removing it makes them more readable.
dont store arbitrary parsed attributes in thir This leads to hard to debug crashes like rust-lang#162811 (comment) cc @JonathanBrouwer @Bryntet @saethlin
…wer,mejrs Use attribute parser for `#[inline()]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer
Remove some #[linkage] options These are either useless due to rustc already setting them whenever you would want them, actively breaking compiler invariants or both. cc rust-lang#29603 (comment)
lint on `Ident::from_str_and_span` taking a string literal This function is a wrapper around `Symbol::intern`, which is already checked by the `rustc::symbol_intern_string_literal` lint. This PR extends that lint to check `Ident::from_str_and_span` as well and updates all affected calls in the compiler. I ran into this when trying to replace some `Ident`s with `Symbol`s.
…=folkertdev Allow `#[repr(simd)]` with `f16b` Fix to allow us to create structs like; ```rust pub struct bfloat16x4_t(f16b x 4); ``` r? folkertdev
Support also `try-jobs:` to specify custom try jobs Suggested by @RalfJung in rust-lang/bors#860. How to test: - `cargo test --manifest-path src/ci/citool/Cargo.toml` - ~~`git diff --check`~~
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 4121ee6 failed: CI. Failed jobs:
|
rust-bors
Bot
removed
the
S-waiting-on-bors
Contributor
|
PR #163405, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
MutTy#163327 (removeMutTy)#[inline()]attribute check #162683 (Use attribute parser for#[inline()]attribute check)Ident::from_str_and_spantaking a string literal #163429 (lint onIdent::from_str_and_spantaking a string literal)#[repr(simd)]withf16b#163431 (Allow#[repr(simd)]withf16b)try-jobs:to specify custom try jobs #163433 (Support alsotry-jobs:to specify custom try jobs)r? @ghost
Create a similar rollup