Skip to content

Rollup of 3 pull requests - #163486

Closed
JonathanBrouwer wants to merge 12 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-jon30yj
Closed

JonathanBrouwer wants to merge 12 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-jon30yj

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

RalfJung and others added 12 commits September 22, 2026 22:56
Adding tests addressing the changes in
coretests/tests/num/clamp_magnitude.rs
Adding mod clamp_magnitude in coretests/num/mod.rs
Activating feature(clamp_magnitude) in coretests/lib.rs
Adding test coverage for f16, f128, and NaN as well as zero cases
Modifying nonzero and int_macros documentation for better readablity
We specialized `advance_by` in rust-lang#141086, so it makes sense to have
`advance_back_by` use the same trick in reverse, i.e. `try_rfold`.

This also updates `nth_back` to mirror `nth`, and the rest of the
`DoubleEndedIterator` methods already match `Iterator`.
…enton

Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`

This adds methods to `Dir` that allow querying the metadata of files/directories relative to a `Dir`. Miri would [really like](rust-lang/miri#5327) to be able to do this so I figured I'd give it a shot. :)

The first commit refactors the Unix `DirEntry` methods a bit with `cfg_select` to avoid repeating the `cfg` condition.

Tracking issue: rust-lang#120426

try-jobs: test-x86_64-msvc-1
…-limit, r=Darksonn

const and NonZero impl for clamp_magnitude()

This PR is implementing the latest proposed changes in Issue rust-lang#148519, making the clamp_magnitude() functions const for all floating point and integer types, as well as adding a clamp_magnitude() to NonZero<$Int>, taking a NonZero<$UInt> as limit parameter.
…rksonn

Specialize `advance_back_by` like the forward version

We specialized `advance_by` in rust-lang#141086, so it makes sense to have
`advance_back_by` use the same trick in reverse, i.e. `try_rfold`.

This also updates `nth_back` to mirror `nth`, and the rest of the
`DoubleEndedIterator` methods already match `Iterator`.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 29, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 29, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d8ff9a0 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026
Rollup of 3 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-gnu-llvm-21-3
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - #163024 (Add `Dir` equivalents of `fs::metadata` & `fs::symlink_metadata`)
 - #163279 (const and NonZero impl for clamp_magnitude())
 - #163361 (Specialize `advance_back_by` like the forward version)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-mingw-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    num::clamp_magnitude::test_clamp_magnitude_f16_panic_negative_limit

test result: FAILED. 2694 passed; 3 failed; 10 ignored; 0 measured; 0 filtered out; finished in 15.19s

error: test failed, to rerun pass `-p coretests --test coretests`
"D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage0\\bin\\cargo.exe" "test" "--manifest-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-codegen\\cg_clif\\build\\sysroot_tests\\Cargo.toml" "--target-dir" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-codegen\\cg_clif\\build\\sysroot_tests_target" "--locked" "--target" "x86_64-pc-windows-gnu" "-p" "coretests" "-p" "alloctests" "--tests" "--" "-q" exited with status ExitStatus(ExitStatus(101))
error: process didn't exit successfully: `D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage3-codegen\x86_64-pc-windows-gnu\release\y.exe test --download-dir D:\a\rust\rust\build\cg_clif_download --out-dir D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2-codegen\cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot` (exit code: 1)
Command `D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin\cargo.exe run --target x86_64-pc-windows-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=D:\a\rust\rust -Zembed-metadata=no --locked --color=always --profile=release --manifest-path D:\a\rust\rust\compiler/rustc_codegen_cranelift/build_system/Cargo.toml -- test --download-dir D:\a\rust\rust\build\cg_clif_download --out-dir D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2-codegen\cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot [workdir=D:\a\rust\rust\compiler/rustc_codegen_cranelift]` failed with exit code 1
Created at: src\bootstrap\src\core\build_steps\test.rs:4419:25
Executed at: src\bootstrap\src\core\build_steps\test.rs:4463:26

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 2 --skip=tests --skip=library --skip=tidyselftest`
Currently active steps:
test::CodegenCranelift { compilers: RustcPrivateCompilers { build_compiler: Compiler { stage: 1, host: x86_64-pc-windows-gnu, forced_compiler: false }, target_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false } }, target: x86_64-pc-windows-gnu } at src\bootstrap\src\core\build_steps\test.rs:4405
Build completed unsuccessfully in 1:36:21
make: *** [Makefile:128: ci-mingw-bootstrap] Error 1

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2026
@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 64d92b2 failed: CI. Failed job:

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 29, 2026
@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

PR #163279, which is a member of this rollup, was unapproved.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2026
@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c9d647a (c9d647abbf9915b5bed322c9a4df8aa64fed447e)
Base parent: b46c90c (b46c90c5619a16a0c7e4d0f4e9e1ad4db4cf106e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants