Rollup of 14 pull requests by JonathanBrouwer · Pull Request #163540 · rust-lang/rust

JonathanBrouwer · 2026-09-30T11:57:24Z

Successful merges:

rustc_codegen_cranelift subtree update #163532 (rustc_codegen_cranelift subtree update)
miri subtree update #163534 (miri subtree update)
add relnotes 1.99.0 #163435 (add relnotes 1.99.0)
const and NonZero impl for clamp_magnitude() #163279 (const and NonZero impl for clamp_magnitude())
Some refactorings around metadata encoding #162900 (Some refactorings around metadata encoding)
Don't use the metadata based crate_hash for rustdoc runs #163455 (Don't use the metadata based crate_hash for rustdoc runs)
Don't build format string suggestions from concat! offsets #163368 (Don't build format string suggestions from concat! offsets)
Miscellaneous attr error stuff #163470 (Miscellaneous attr error stuff)
x86 and x86_64: cleanup some callconv code #163492 (x86 and x86_64: cleanup some callconv code)
cycle handling: mirror old solver #163496 (cycle handling: mirror old solver)
Use more default field values in Resolver #163509 (Use more default field values in Resolver)
Forbid Reborrow impls for types with destructors #163519 (Forbid Reborrow impls for types with destructors)
Cast cleanups #163520 (Cast cleanups)
Document Result case for the arena_cache query modifier #163524 (Document Result case for the arena_cache query modifier)

… metadata tables

This updates the rust-toolchain.toml file to nightly-2026-09-18.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@330d317 Filtered ref: rust-lang/rustc_codegen_cranelift@3e5b427 Upstream diff: rust-lang/rust@67eda61...330d317 This merge was created using https://github.com/rust-lang/josh-sync.

…ly when `ProcMacroData` is `Some`

…ome` and `record_defaulted` -> `record_value`

Update `rustup.sh` to use `rustc-josh-sync`

as emitted by the `_mm256_clmulepi64_epi128` and ` _mm512_clmulepi64_epi128` intrinsics

support `vpclmulqdq`

Integrate `stdarch` tests for aarch64

This updates the rust-toolchain.toml file to nightly-2026-09-22.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@1303417 Filtered ref: rust-lang/rustc_codegen_cranelift@ca3fb81 Upstream diff: rust-lang/rust@330d317...1303417 This merge was created using https://github.com/rust-lang/josh-sync.

This updates the rust-toolchain.toml file to nightly-2026-09-23 (6bb1652).

Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@1303417 New upstream ref: rust-lang/rust@6bb1652 Filtered ref: rust-lang/rustc_codegen_cranelift@0ba93c5 Upstream diff: rust-lang/rust@1303417...6bb1652 This merge was created using https://github.com/rust-lang/josh-sync.

…nZero<T>

This updates the rust-version file to 3670d25.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@88638df New upstream ref: rust-lang/rust@3670d25 Filtered ref: rust-lang/miri@40409ba Upstream diff: rust-lang/rust@88638df...3670d25 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

Adding tests addressing the changes in coretests/tests/num/clamp_magnitude.rs

This updates the rust-version file to 0d38a84.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@3670d25 New upstream ref: rust-lang/rust@0d38a84 Filtered ref: rust-lang/miri@d0cef69 Upstream diff: rust-lang/rust@3670d25...0d38a84 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

Adding mod clamp_magnitude in coretests/num/mod.rs Activating feature(clamp_magnitude) in coretests/lib.rs Adding test coverage for f16, f128, and NaN as well as zero cases Modifying nonzero and int_macros documentation for better readablity

…s-zed Disable rust-analyzer diagnostics for Zed

@jackh726

…h726 cycle handling: mirror old solver I hate other people being right :< When stabilizing the new solver, we really want to minimize the amount of things we're stabilizing. This far more closely matches the old solver while still being somewhat principled. I do think the approach we had before this PR is closer to the final state we want, but I am far from confident that this is the case and this gives us more room to experiment until then. The rules are as follows: a cycle is coinductive if there's at least one "coinductive trait goal" involved and the only other involved goals are `Projection` goals. r? types cc @jackh726

@petrochenkov

Use more default field values in `Resolver` Minor clean up by adding a way to construct `const FxIndexSet`/`Map`s and then using that in `Resolver`'s default fields. r? @petrochenkov

@aapoalas

…ctor, r=mejrs Forbid `Reborrow` impls for types with destructors Construction of such types should never be so implicit. Tracking issue: rust-lang#145612 cc @aapoalas @rustbot label F-reborrow A-destructors

@oli-obk

Cast cleanups At one point I was looking at merging `ast::IntTy` and `ast::UintTy` into a single type. In the end I decided against that, but I did find some related code, mostly involving casts, that deserved some cleanups. Details in individual commits. r? @oli-obk

@Zalathar

…, r=Zalathar Document `Result` case for the `arena_cache` query modifier r? @Zalathar

JonathanBrouwer · 2026-09-30T11:57:35Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

rust-bors · 2026-09-30T11:57:39Z

📌 Commit 5c09ea5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-09-30T11:57:46Z

⌛ Trying commit 5c09ea5 with merge 3135961…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/36711757467

Rollup of 14 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu

rust-log-analyzer · 2026-09-30T12:02:34Z

The job test-aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_mir_dataflow v0.0.0 (/checkout/compiler/rustc_mir_dataflow)
error[E0107]: struct takes 3 generic arguments but 2 generic arguments were supplied
   --> compiler/rustc_metadata/src/rmeta/mod.rs:217:30
    |
217 |     proc_macro_quoted_spans: LazyTable<usize, Option<LazyValue<Span>>>,
    |                              ^^^^^^^^^ -----  ----------------------- supplied 2 generic arguments
    |                              |
    |                              expected 3 generic arguments
    |
note: struct defined here, with 3 generic parameters: `IdxEncode`, `IdxDecode`, `T`
   --> compiler/rustc_metadata/src/rmeta/mod.rs:150:8
    |
150 | struct LazyTable<IdxEncode, IdxDecode, T> {
    |        ^^^^^^^^^ ---------  ---------  -
help: add missing generic argument
    |
217 |     proc_macro_quoted_spans: LazyTable<usize, Option<LazyValue<Span>>, T>,
    |                                                                      +++

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2138:67
     |
2138 |             let proc_macro_quoted_spans = proc_macro_quoted_spans.encode(&mut self.opaque);
     |                                                                   ^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder::<Ie, Id, T>::encode`
    --> compiler/rustc_metadata/src/rmeta/table.rs:453:19
     |
 453 | impl<Ie: Idx, Id: Idx, const N: usize, T: FixedSizeEncoding<ByteArray = [u8; N]>>
     |                   ^^^ required by this bound in `TableBuilder::<Ie, Id, T>::encode`
...
 484 |     pub(crate) fn encode(&self, buf: &mut FileEncoder<'_>) -> LazyTable<Ie, Id, T> {
     |                   ------ required by a bound in this associated function

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2135:41
     |
2135 |                 proc_macro_quoted_spans.set_some(i, self.lazy(span));
     |                                         ^^^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder::<Ie, Id, std::option::Option<T>>::set_some`
    --> compiler/rustc_metadata/src/rmeta/table.rs:444:19
     |
 444 | impl<Ie: Idx, Id: Idx, const N: usize, T> TableBuilder<Ie, Id, Option<T>>
     |                   ^^^ required by this bound in `TableBuilder::<Ie, Id, Option<T>>::set_some`
...
 448 |     pub(crate) fn set_some(&mut self, i: Ie, value: T) {
     |                   -------- required by a bound in this associated function

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2133:47
     |
2133 |             let mut proc_macro_quoted_spans = TableBuilder::default();
     |                                               ^^^^^^^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder`
    --> compiler/rustc_metadata/src/rmeta/table.rs:430:59
     |
 430 | pub(super) struct TableBuilder<IdxEncode: Idx, IdxDecode: Idx, T: FixedSizeEncoding> {
     |                                                           ^^^ required by this bound in `TableBuilder`

Some errors have detailed explanations: E0107, E0277.
For more information about an error, try `rustc --explain E0107`.
[RUSTC-TIMING] rustc_metadata test:false 1.599

rust-log-analyzer · 2026-09-30T12:04:16Z

The job test-x86_64-gnu-llvm-21-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_mir_dataflow v0.0.0 (/checkout/compiler/rustc_mir_dataflow)
error[E0107]: struct takes 3 generic arguments but 2 generic arguments were supplied
   --> compiler/rustc_metadata/src/rmeta/mod.rs:217:30
    |
217 |     proc_macro_quoted_spans: LazyTable<usize, Option<LazyValue<Span>>>,
    |                              ^^^^^^^^^ -----  ----------------------- supplied 2 generic arguments
    |                              |
    |                              expected 3 generic arguments
    |
note: struct defined here, with 3 generic parameters: `IdxEncode`, `IdxDecode`, `T`
   --> compiler/rustc_metadata/src/rmeta/mod.rs:150:8
    |
150 | struct LazyTable<IdxEncode, IdxDecode, T> {
    |        ^^^^^^^^^ ---------  ---------  -
help: add missing generic argument
    |
217 |     proc_macro_quoted_spans: LazyTable<usize, Option<LazyValue<Span>>, T>,
    |                                                                      +++

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2138:67
     |
2138 |             let proc_macro_quoted_spans = proc_macro_quoted_spans.encode(&mut self.opaque);
     |                                                                   ^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder::<Ie, Id, T>::encode`
    --> compiler/rustc_metadata/src/rmeta/table.rs:453:19
     |
 453 | impl<Ie: Idx, Id: Idx, const N: usize, T: FixedSizeEncoding<ByteArray = [u8; N]>>
     |                   ^^^ required by this bound in `TableBuilder::<Ie, Id, T>::encode`
...
 484 |     pub(crate) fn encode(&self, buf: &mut FileEncoder<'_>) -> LazyTable<Ie, Id, T> {
     |                   ------ required by a bound in this associated function

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2135:41
     |
2135 |                 proc_macro_quoted_spans.set_some(i, self.lazy(span));
     |                                         ^^^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder::<Ie, Id, std::option::Option<T>>::set_some`
    --> compiler/rustc_metadata/src/rmeta/table.rs:444:19
     |
 444 | impl<Ie: Idx, Id: Idx, const N: usize, T> TableBuilder<Ie, Id, Option<T>>
     |                   ^^^ required by this bound in `TableBuilder::<Ie, Id, Option<T>>::set_some`
...
 448 |     pub(crate) fn set_some(&mut self, i: Ie, value: T) {
     |                   -------- required by a bound in this associated function

error[E0277]: the trait bound `std::option::Option<rmeta::LazyValue<rustc_span::Span>>: Idx` is not satisfied
    --> compiler/rustc_metadata/src/rmeta/encoder.rs:2133:47
     |
2133 |             let mut proc_macro_quoted_spans = TableBuilder::default();
     |                                               ^^^^^^^^^^^^ the trait `Idx` is not implemented for `std::option::Option<rmeta::LazyValue<rustc_span::Span>>`
     |
     = help: the following other types implement trait `Idx`:
               ArmId
               AttrId
               BasicCoverageBlock
---
             and 33 others
note: required by a bound in `table::TableBuilder`
    --> compiler/rustc_metadata/src/rmeta/table.rs:430:59
     |
 430 | pub(super) struct TableBuilder<IdxEncode: Idx, IdxDecode: Idx, T: FixedSizeEncoding> {
     |                                                           ^^^ required by this bound in `TableBuilder`

Some errors have detailed explanations: E0107, E0277.
For more information about an error, try `rustc --explain E0107`.
[RUSTC-TIMING] rustc_metadata test:false 1.638

rust-bors · 2026-09-30T12:06:44Z

PR #162900, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

JonathanBrouwer · 2026-09-30T12:07:44Z

@bors try cancel

rust-bors · 2026-09-30T12:07:48Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/36711757467

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

bjorn3 and others added 30 commits September 15, 2026 14:31

Use nightly sync mode for josh-sync

7488140

Introduce record_non_lazy and record_defaulted macros to write to…

574e8d2

… metadata tables

Prepare for merging from rust-lang/rust

d3cc844

This updates the rust-toolchain.toml file to nightly-2026-09-18.

Move proc_macro_quoted_spans to ProcMacroData, as it is filled on…

020ffe1

…ly when `ProcMacroData` is `Some`

Rename record -> record_some_lazy, record_non_lazy -> `record_s…

3033e33

…ome` and `record_defaulted` -> `record_value`

Merge pull request rust-lang#1702 from Kobzol/josh-sync-script

0ef25a5

Update `rustup.sh` to use `rustc-josh-sync`

enable __powitf2

9204d85

support vpclmulqdq

f952ea0

as emitted by the `_mm256_clmulepi64_epi128` and ` _mm512_clmulepi64_epi128` intrinsics

enable __powitf2 (rust-lang#1704)

465eff3

Merge pull request rust-lang#1705 from folkertdev/vpclmulqdq

2d64a2a

support `vpclmulqdq`

Integrate stdarch tests for aarch64

ff88d0d

Merge pull request rust-lang#1667 from CathalMullan/stdarch

df476a9

Integrate `stdarch` tests for aarch64

Prepare for merging from rust-lang/rust

711bae4

This updates the rust-toolchain.toml file to nightly-2026-09-22.

Prepare for merging from rust-lang/rust

29ff6f9

This updates the rust-toolchain.toml file to nightly-2026-09-23 (6bb1652).

making clamp_magnitude functions const + adding clamp_magnitude to No…

dc39f01

…nZero<T>

Prepare for merging from rust-lang/rust

c614782

This updates the rust-version file to 3670d25.

temporarily disable broken test on freebsd

ec11203

Merge pull request rust-lang#5343 from rust-lang/rustup-2026-09-24

6cdd4d4

Automatic Rustup

adding coretests and fixing docs

d6d250c

Adding tests addressing the changes in coretests/tests/num/clamp_magnitude.rs

Prepare for merging from rust-lang/rust

76384db

This updates the rust-version file to 0d38a84.

Merge pull request rust-lang#5346 from rust-lang/rustup-2026-09-25

801c6d7

Automatic Rustup

run windows-fs tests natively

79cbf77

Applying requested changes

3f2e9ee

Adding mod clamp_magnitude in coretests/num/mod.rs Activating feature(clamp_magnitude) in coretests/lib.rs Adding test coverage for f16, f128, and NaN as well as zero cases Modifying nonzero and int_macros documentation for better readablity

Disable RA diagnostics due to many false positives

eb7e04d

Merge pull request rust-lang#5347 from WhySoBad/disable-RA-diagnostic…

cc51d68

…s-zed Disable rust-analyzer diagnostics for Zed

JonathanBrouwer added 5 commits September 30, 2026 13:57

Rollup merge of rust-lang#163509 - estebank:default-more, r=petrochenkov

24efd6d

Use more default field values in `Resolver` Minor clean up by adding a way to construct `const FxIndexSet`/`Map`s and then using that in `Resolver`'s default fields. r? @petrochenkov

Rollup merge of rust-lang#163519 - Jules-Bertholet:no-reborrow-destru…

c18efec

…ctor, r=mejrs Forbid `Reborrow` impls for types with destructors Construction of such types should never be so implicit. Tracking issue: rust-lang#145612 cc @aapoalas @rustbot label F-reborrow A-destructors

Rollup merge of rust-lang#163524 - nnethercote:arena_cache-Result-doc…

5c09ea5

…, r=Zalathar Document `Result` case for the `arena_cache` query modifier r? @Zalathar

rust-bors Bot added the rollup A PR which is a rollup label Sep 30, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2026

JonathanBrouwer mentioned this pull request Sep 30, 2026

Some refactorings around metadata encoding #162900

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2026

JonathanBrouwer closed this Sep 30, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 30, 2026

Navigation Menu

Uh oh!

Rollup of 14 pull requests - #163540

Rollup of 14 pull requests#163540
JonathanBrouwer wants to merge 107 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-IgEalS5

JonathanBrouwer commented Sep 30, 2026

Uh oh!

JonathanBrouwer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Sep 30, 2026

Uh oh!

rust-log-analyzer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

JonathanBrouwer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

JonathanBrouwer commented Sep 30, 2026

Uh oh!

JonathanBrouwer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Sep 30, 2026

Uh oh!

rust-log-analyzer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

JonathanBrouwer commented Sep 30, 2026

Uh oh!

rust-bors Bot commented Sep 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rust-bors Bot commented Sep 30, 2026 •

edited

Loading