Repository navigation
Conversation
Collaborator
|
Any special-casing of Miri in the standard library requires review. cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
DirEntry::metadata: use dirfd everywhere that we support Dir try-job: *bsd* try-job: *various*
RalfJung
changed the title
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
September 30, 2026 14:14
9f3dc8b to
90ee551
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
September 30, 2026 15:06
90ee551 to
a6b3a69
Compare
Member
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
DirEntry::metadata: use dirfd on more targets try-job: *bsd* try-job: *various*
Contributor
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
October 2, 2026 20:53
a6b3a69 to
c97c7de
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
October 2, 2026 20:55
c97c7de to
6a7b5dd
Compare
RalfJung
commented
Oct 2, 2026
| target_os = "nto", | ||
| target_os = "qnx", | ||
| target_os = "vita", | ||
| target_os = "hurd", |
Member
Author
There was a problem hiding this comment.
hurd has dirfd according to libc, and we've been using it for DirEntry::metadata, so it should be fine to use here as well.
RalfJung
commented
Oct 2, 2026
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
October 3, 2026 10:43
6a7b5dd to
3b1fc44
Compare
RalfJung
force-pushed
the
dir-entry-metadata
branch
from
October 3, 2026 18:36
3b1fc44 to
46b2135
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the BSDs support
dirfdandfstatatjust fine but for some reason we've not been using it forDirEntry::metadata. This syncs thecfgfor usingdirfdwith the one that we use inDir::closefor the FD sanity check. Those target evidently all havedirfdas we're using it there, and that's a strict subset of the targets that haveDirhandles, so they should supportfstatatas well.try-job: bsd
try-job: various