Repository navigation
Rollup of 3 pull requests - #163686
Closed
JonathanBrouwer wants to merge 7 commits into
Closed
Rollup of 3 pull requests#163686JonathanBrouwer wants to merge 7 commits into
JonathanBrouwer wants to merge 7 commits into
Conversation
When building `core` with `--cfg no_io_statics`, the compiler warns:
error: unused variable: `f`
--> .../library/core/src/io/error/os_functions.rs:9:36
|
9 | pub(super) unsafe fn set_functions(f: &'static OsFunctions) {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Thus clean it up.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Similar to the existing tests for other `cfg`s like `no_fp_fmt_parse`, add one for `no_io_statics`. This should prevent issues like the one in the parent commit. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
We are refactoring from a large enum where the fields of the variants contain all the reflection info to a flat enum containing only the type kind (struct/bool/array etc). While we removed the fields of Struct, Enum and Union we forgot to take out the const eval code writing into those fields. That gave an ICE. This fixes that.
…fo, r=oli-obk reflection: fix ICE when TypeId::info called on ADT We are refactoring from a large enum where the fields of the variants contain all the reflection info to a flat enum containing only the type kind (struct/bool/array etc). While we removed the fields of Struct, Enum and Union we forgot to take out the const eval code writing into those fields. That gave an ICE. This fixes that.
…s, r=JohnTitor
core: io: clean `unused_variables` lint under `no_io_statics`
When building `core` with `--cfg no_io_statics`, the compiler warns:
error: unused variable: `f`
--> .../library/core/src/io/error/os_functions.rs:9:36
|
9 | pub(super) unsafe fn set_functions(f: &'static OsFunctions) {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Thus clean it up.
---
If the signature is preferred to be exactly the same one as the `os_functions_atomic.rs` one, then we could `allow` it instead.
…, r=traviscross Make the tracking issue template better suited for experiments The lang team's experiment docs say to create a tracking issue, but the tracking issue template isn't well suited for features that lack an RFC. These are minor changes that should streamline the process. Thanks to @diondokter for pointing out how these could be improved. r? lang-ops
rustbot
added
A-run-make
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup of 3 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for f29881c failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
removed
the
S-waiting-on-bors
rustbot
removed
the
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
unused_variableslint underno_io_statics#163633 (core: io: cleanunused_variableslint underno_io_statics)r? @ghost
Create a similar rollup