Skip to content

Bootstrap: reorder tools to properly reflect their build order - #74128

Closed
mati865 wants to merge 1 commit into
rust-lang:masterfrom
mati865:tools-build-order
Closed

mati865 wants to merge 1 commit into
rust-lang:masterfrom
mati865:tools-build-order

Conversation

@mati865

@mati865 mati865 commented Jul 7, 2020 •

Copy link
Copy Markdown
Member

Noticed in #74016 (comment)

RLS depends on Clippy and Rustfmt.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2020
@mati865
mati865 force-pushed the tools-build-order branch from 52b64f7 to 3b88332 Compare July 7, 2020 15:48
@mati865
mati865 force-pushed the tools-build-order branch from 3b88332 to 7c6258d Compare July 7, 2020 15:50
@mati865

mati865 commented Jul 7, 2020

Copy link
Copy Markdown
Member Author

Also cc @ehuss

@Mark-Simulacrum

Copy link
Copy Markdown
Member

I don't have time to repeat @ehuss' investigative work here, so let's r? @ehuss

@ehuss

ehuss commented Jul 8, 2020 •

Copy link
Copy Markdown
Contributor

This doesn't actually change the order, at least for x.py dist. The order is defined by the Extended step.

Although changing the order can help a little, I still think it is more important to merge #74046, which should significantly reduce the rebuilds.

It looks like rust-analyzer is also causing some issues, I'm going to investigate that more.

@mati865

mati865 commented Jul 8, 2020

Copy link
Copy Markdown
Member Author

Order in get_step_descriptions matters for test subcommand and I assumed dist would also follow it. Sorry for the noise.

@mati865 mati865 closed this Jul 8, 2020
@mati865
mati865 deleted the tools-build-order branch August 12, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants