Rollup of 9 pull requests by Dylan-DPC · Pull Request #96108 · rust-lang/rust

Dylan-DPC · 2022-04-16T05:12:50Z

Successful merges:

Only add codegen backend to dep info if -Zbinary-dep-depinfo is used #93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used)
Add missing links in platform support docs #94605 (Add missing links in platform support docs)
make unaligned_references lint deny-by-default and make it show up in future-breakage report #95372 (make unaligned_references lint deny-by-default)
Improve diagnostics for unterminated nested block comment #95859 (Improve diagnostics for unterminated nested block comment)
implement SIMD gather/scatter via vector getelementptr #95961 (implement SIMD gather/scatter via vector getelementptr)
Consider lifetimes when comparing types for equality in MIR validator #96004 (Consider lifetimes when comparing types for equality in MIR validator)
Remove some now-dead code that was only relevant before deaggregation. #96050 (Remove some now-dead code that was only relevant before deaggregation.)
[test] Add test cases for untested functions for BTreeMap #96070 ([test] Add test cases for untested functions for BTreeMap)
MaybeUninit array cleanup #96099 (MaybeUninit array cleanup)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Also sort sidebar alphabetically by document filename

The code was broken anyway, if the deaggregator is disabled, it would have ICE on any non-enum Adt

* Links MaybeUninit::uninit_array to meta-tracking issue * Links MaybeUninit::array_assume_init to meta-tracking issue * Unstably constifies MaybeUninit::array_assume_init

…pnkfelix Only add codegen backend to dep info if -Zbinary-dep-depinfo is used I am currently migrating the cg_clif build system from using a binary linked to the codegen backend as rustc replacement to passing `-Zcodegen-backend` instead. Without this PR this would force cargo to rebuild the sysroot on any change to the codegen backend even if I explicitly specify that I want it to be preserved, which would make development of cg_clif a lot slower. If you still want to have changes to the codegen backend invalidate the cargo build cache you can explicitly specify `-Zbinary-dep-depinfo`. cc ``@eddyb`` as the codegen backend was initially added to the depinfo for rust-gpu.

Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation

…i-obk make unaligned_references lint deny-by-default This lint has been warn-by-default for a year now (since rust-lang#82525), so I think it is time to crank it up a bit. Code that triggers the lint causes UB (without `unsafe`) when executed, so we really don't want people to write code like this.

…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )

…ubilee implement SIMD gather/scatter via vector getelementptr Fixes rust-lang/portable-simd#271 However, I don't *really* know what I am doing here... Cc ``@workingjubilee`` ``@calebzulawski`` I didn't do anything for cranelift -- ``@bjorn3`` not sure if it's okay for that backend to temporarily break. I'm happy to cherry-pick a patch that adds cranelift support. :)

…rochenkov Consider lifetimes when comparing types for equality in MIR validator Closes rust-lang#95978 .

…fJung Remove some now-dead code that was only relevant before deaggregation. The code was broken anyway, if the deaggregator is disabled, it would have ICEd on any non-enum Adt r? ```@RalfJung```

…thomcc [test] Add test cases for untested functions for BTreeMap - add `pop_first()`, `pop_last()`, `get_key_value()` and `try_insert()` test cases

…up, r=dtolnay MaybeUninit array cleanup * Links `MaybeUninit::uninit_array` to meta-tracking issue * Links `MaybeUninit::array_assume_init` to meta-tracking issue * Unstably constifies `MaybeUninit::array_assume_init` Another thing worth mentioning: this splits the const feature flag for `maybe_uninit_uninit_array` into `const_maybe_uninit_uninit_array` to avoid weird cases where only one gets stabilised. Note that it may be desired to keep the `array_assume_init` method linked to its dedicated issue, but at least for now, I decided to link to the meta-tracking issue so that all of the methods lead users to the same place. But I can revert that bit if desired. The meta-tracking issue that I filed is rust-lang#96097.

Dylan-DPC · 2022-04-16T05:13:12Z

@bors r+ rollup=never p=5

bors · 2022-04-16T05:13:13Z

📌 Commit f559cf9 has been approved by Dylan-DPC

bors · 2022-04-16T09:19:30Z

⌛ Testing commit f559cf9 with merge c842240...

bors · 2022-04-16T11:43:23Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing c842240 to master...

rust-highfive · 2022-04-16T11:44:03Z

📣 Toolstate changed by #96108!

Tested on commit c842240.
Direct link to PR: #96108

💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
💔 embedded-book on windows: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig).
💔 embedded-book on linux: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig).

@RalfJung

Tested on commit rust-lang/rust@c842240. Direct link to PR: <rust-lang/rust#96108> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 embedded-book on windows: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig). 💔 embedded-book on linux: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig).

rust-timer · 2022-04-16T12:57:13Z

Finished benchmarking commit (c842240): comparison url.

Summary:

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	3	0	2	0
mean²	N/A	1.1%	N/A	-0.5%	N/A
max	N/A	1.1%	N/A	-0.7%	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

317: Fix use of unaligned references in example r=eldruin a=adamgreig A recent change in Rust to deny unaligned reference by default (rust-lang/rust#95372) caused the upstream rust build of this book to break: rust-lang/rust#96108 (comment) This PR removes the unaligned references, instead using `addr_of!()` to get a raw pointer to print. Co-authored-by: Adam Greig <adam@adamgreig.com>

pnkfelix · 2022-04-21T02:37:24Z

This observed 1% regression on ctfe-stress-5.
Much like PR Rollup of 6 pull requests #96015, I do not think I would put individual blame on this rollup PR for the problems we may be seeing over time in ctfe-stress-5.

@rustbot label: +perf-regression-triaged

317: Fix use of unaligned references in example r=eldruin a=adamgreig A recent change in Rust to deny unaligned reference by default (rust-lang/rust#95372) caused the upstream rust build of this book to break: rust-lang/rust#96108 (comment) This PR removes the unaligned references, instead using `addr_of!()` to get a raw pointer to print. Co-authored-by: Adam Greig <adam@adamgreig.com>

Michcioperz and others added 28 commits March 4, 2022 13:39

Add platform support document links to tier table

d78e3e3

Add missing platform support docs to sidebar

c1d5c2b

Also sort sidebar alphabetically by document filename

Only add codegen backend to dep info if -Zbinary-dep-depinfo is used

9cfdb89

Don't include invalid paths in the depinfo for builtin backends

c681a88

Add test

147e5da

add simd_arith_offset intrinsics

7f945b2

portable-simd: use simd_arith_offset to avoid ptr-int transmutation

e886dc5

Consider lifetimes when comparing types for equality in MIR validator

d5f3863

improve diagnostics for unterminated nested block comment

4a0f8d5

refactor: change to use peekable

1b7008d

Remove some now-dead code that was only relevant before deaggregation.

48029ab

The code was broken anyway, if the deaggregator is disabled, it would have ICE on any non-enum Adt

make unaligned_references lint deny-by-default

e30d6d9

make unaligned_reference warning visible in future compat report

1a6c2ff

test: add pop_first() pop_last() test cases for BTreeSet

4117e8c

test: add get_key_value() test cases for BTreeSet

e162602

test: add try_insert() test cases for BTreeSet

3f2f4a3

chore: formatting

3f46ba6

add codegen smoke test

73f9571

MaybeUninit array cleanup

63a8652

* Links MaybeUninit::uninit_array to meta-tracking issue * Links MaybeUninit::array_assume_init to meta-tracking issue * Unstably constifies MaybeUninit::array_assume_init

Rollup merge of rust-lang#94605 - Michcioperz:patch-1, r=pnkfelix

6dd92bf

Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation

Rollup merge of rust-lang#96004 - JakobDegen:fix-validator-ice, r=pet…

fd7a1f1

…rochenkov Consider lifetimes when comparing types for equality in MIR validator Closes rust-lang#95978 .

Rollup merge of rust-lang#96050 - oli-obk:deaggregator_cleanup, r=Ral…

ab7fb29

…fJung Remove some now-dead code that was only relevant before deaggregation. The code was broken anyway, if the deaggregator is disabled, it would have ICEd on any non-enum Adt r? ```@RalfJung```

Rollup merge of rust-lang#96070 - Gumichocopengin8:test/btree-map, r=…

04ccba8

…thomcc [test] Add test cases for untested functions for BTreeMap - add `pop_first()`, `pop_last()`, `get_key_value()` and `try_insert()` test cases

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2022

rustbot added the rollup A PR which is a rollup label Apr 16, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2022

bors merged commit c842240 into rust-lang:master Apr 16, 2022

rustbot added this to the 1.62.0 milestone Apr 16, 2022

rust-highfive mentioned this pull request Apr 16, 2022

miri no longer builds after rust-lang/rust#96108 #96115

Closed

bors mentioned this pull request Apr 16, 2022

Add MVP LLVM based mingw-w64 targets #94872

Merged

rustbot added the perf-regression Performance regression. label Apr 16, 2022

ehuss mentioned this pull request Apr 16, 2022

Update mdbook #96088

Merged

Dylan-DPC deleted the rollup-t5f2fc9 branch April 16, 2022 21:41

adamgreig mentioned this pull request Apr 19, 2022

Fix use of unaligned references in example rust-embedded/book#317

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 21, 2022

pnkfelix mentioned this pull request Apr 21, 2022

Rollup of 7 pull requests #96117

Merged

rylev mentioned this pull request Apr 25, 2022

Change deserves_attention algorithm rust-lang/rustc-perf#1309

Merged

Navigation Menu

Uh oh!

Uh oh!

Rollup of 9 pull requests - #96108

Rollup of 9 pull requests#96108
bors merged 28 commits into
rust-lang:masterfrom
Dylan-DPC:rollup-t5f2fc9

Dylan-DPC commented Apr 16, 2022

Uh oh!

Dylan-DPC commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

rust-highfive commented Apr 16, 2022

Uh oh!

rust-timer commented Apr 16, 2022

Uh oh!

pnkfelix commented Apr 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Uh oh!

Conversation

Dylan-DPC commented Apr 16, 2022

Uh oh!

Dylan-DPC commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

bors commented Apr 16, 2022

Uh oh!

rust-highfive commented Apr 16, 2022

Uh oh!

rust-timer commented Apr 16, 2022

Footnotes

Uh oh!

pnkfelix commented Apr 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants