Enable triagebot issue-links - #7098
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
requested changes
Sep 3, 2026
| # Canonicalize issue numbers to avoid closing the wrong issue | ||
| # when commits are included in subtrees, as well as warning links in commits. | ||
| # Documentation at: https://forge.rust-lang.org/triagebot/issue-links.html | ||
| [issue-links] |
Contributor
There was a problem hiding this comment.
Per the docs I think we should also add check-commits = "uncanonicalized" # for subtrees
Suggested change
| [issue-links] | |
| [issue-links] | |
| # This prevents links from resolving to the wrong repository when the subtree is merged upstream while still allowing issue links in commits. | |
| check-commits = "uncanonicalized" |
rustbot
added
S-waiting-on-author
jieyouxu
force-pushed
the
canon-issue-links
branch
from
September 4, 2026 07:42
bb24306 to
1f95ab7
Compare
Member
Author
|
Changes since last review:
@rustbot review |
rustbot
added
S-waiting-on-review
ytmimi
approved these changes
Sep 4, 2026
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #7095 (comment), triagebot has a functionality to:
Fixes #123456in commit descriptions.The
Fixes #123456form triggers github magic comments, which will close the same issue number / PR but on the wrong repo when syncing subtrees.