fix: prevent ICE on lifetime-only macro arguments - #7100
Open
saberoueslati wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7034.
Problem
Malformed macro arguments ending in
&'atrigger rustc’s pattern parser, which creates an empty suggestion span at EOF and trips a debug assertion.&&'avariants are also affected because&&is parsed as nested&tokens.Fix
Skip speculative pattern parsing when a run of
&/&&tokens is followed by a lifetime. Valid types remain unaffected, and rustfmt uses its existing unparseable-macro fallback.Testing
Added
&'a,&&'a, and&&&'acases todont_emit_ICE. Fullcargo testpasses.LLM was used to understand the issue and as an extra reviewer for my code