Skip to content

refactor(dist/manifest): extract Component::std() - #5062

Merged
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:copilot/refactor-extract-std-constructor
Sep 7, 2026
Merged

refactor(dist/manifest): extract Component::std()#5062
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:copilot/refactor-extract-std-constructor

Conversation

@rami3l

@rami3l rami3l commented Sep 7, 2026

Copy link
Copy Markdown
Member

Note

This PR is generated by GitHub Copilot on GPT 5.6 Luna, with manual review and minor adjustments.

Addresses the concern in #5054 (review).

@rustbot

This comment has been minimized.

@rami3l
rami3l force-pushed the copilot/refactor-extract-std-constructor branch from 08c1426 to e7b63df Compare September 7, 2026 11:15
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This comment was marked as resolved.

Comment thread Cargo.toml
description = "Manage multiple rust installations with ease"
homepage = "https://github.com/rust-lang/rustup"
keywords = ["rustup", "multirust", "install", "proxy"]
readme = "README.md"

@rami3l rami3l Sep 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo now says that it can deduce those values and thus suggests removing them altogether.

The same thing has happened to another project of mine: rami3l/pacaptr@19d2cd6

View changes since the review

@rami3l
rami3l requested a review from djc September 7, 2026 11:24
Comment thread src/cli/rustup_mode.rs Outdated
@rami3l
rami3l force-pushed the copilot/refactor-extract-std-constructor branch from e7b63df to fd9dfff Compare September 7, 2026 11:34
@rami3l
rami3l added this pull request to the merge queue Sep 7, 2026
Merged via the queue into rust-lang:main with commit f6c72ea Sep 7, 2026
31 checks passed
@rami3l
rami3l deleted the copilot/refactor-extract-std-constructor branch September 7, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants