Skip to content

fix(windows): match complete PATH entries when adding and removing - #5067

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
Cloud0310:fix-windows-path-match
Sep 10, 2026
Merged

fix(windows): match complete PATH entries when adding and removing#5067
rami3l merged 1 commit into
rust-lang:mainfrom
Cloud0310:fix-windows-path-match

Conversation

@Cloud0310

Copy link
Copy Markdown
Contributor

Fix Windows potentially adding/removing wrong PATH entry.

Comment thread src/cli/self_update/windows.rs Outdated
Comment thread src/cli/self_update/windows.rs Outdated
@Cloud0310
Cloud0310 requested a review from rami3l September 10, 2026 07:02

@djc djc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also it doesn't really appear like the first two commits are really independent?)

View changes since this review

Comment thread src/cli/self_update/windows.rs Outdated
@Cloud0310
Cloud0310 force-pushed the fix-windows-path-match branch 2 times, most recently from 6b57f60 to 70c4ce7 Compare September 10, 2026 08:37
Comment thread src/cli/self_update/windows.rs Outdated
Comment thread src/cli/self_update/windows.rs Outdated
@Cloud0310
Cloud0310 force-pushed the fix-windows-path-match branch from 70c4ce7 to 6981a67 Compare September 10, 2026 09:34
@Cloud0310
Cloud0310 force-pushed the fix-windows-path-match branch from 6981a67 to 1fde9c7 Compare September 10, 2026 10:20
@rami3l
rami3l added this pull request to the merge queue Sep 10, 2026
Merged via the queue into rust-lang:main with commit 7df2ba0 Sep 10, 2026
31 checks passed
@rami3l
rami3l deleted the fix-windows-path-match branch September 10, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants